You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "biyuhao (GitHub)" <gi...@apache.org> on 2018/12/18 15:12:18 UTC
[GitHub] [incubator-dubbo] biyuhao opened pull request #3009: Add
dubbo-monitor-logstash
I'm not sure if this feature can goes to the core dubbo framework.
But we can still use this PR for code review and discussion.
## What is the purpose of the change
Add dubbo monitor extension for logstash.
## Brief changelog
Add a new module called dubbo-monitor-logstash
core feature:
- act as a client for logstash-tcp-input
- jsonline format or URL-like palintext format
- one-way or two-way SSL authentication
- auto re-connect
## Verifying this change
Please run unit test from local.
You can start with a demo here
https://github.com/biyuhao/dubbo-samples-monitor-logstash
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3009 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] biyuhao commented on issue #3009: Add
dubbo-monitor-logstash
Posted by "biyuhao (GitHub)" <gi...@apache.org>.
Of course! I'm pleased to participate, let's do it.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3009 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] biyuhao closed pull request #3009: Add
dubbo-monitor-logstash
Posted by "biyuhao (GitHub)" <gi...@apache.org>.
[ pull request closed by biyuhao ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3009 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3009: Add
dubbo-monitor-logstash
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3009?src=pr&el=h1) Report
> Merging [#3009](https://codecov.io/gh/apache/incubator-dubbo/pull/3009?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/df219f36aa27f6fd11c33a73af407b9e009485a7?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `58.37%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3009?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3009 +/- ##
=========================================
- Coverage 64.32% 64.23% -0.1%
=========================================
Files 584 589 +5
Lines 26056 26253 +197
Branches 4562 4582 +20
=========================================
+ Hits 16761 16863 +102
- Misses 7113 7200 +87
- Partials 2182 2190 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3009?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ubbo/monitor/logstash/PlainMonitorDataEncoder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWxvZ3N0YXNoL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tb25pdG9yL2xvZ3N0YXNoL1BsYWluTW9uaXRvckRhdGFFbmNvZGVyLmphdmE=) | `0% <0%> (ø)` | |
| [...org/apache/dubbo/monitor/logstash/MonitorData.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWxvZ3N0YXNoL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tb25pdG9yL2xvZ3N0YXNoL01vbml0b3JEYXRhLmphdmE=) | `100% <100%> (ø)` | |
| [...dubbo/monitor/logstash/JsonMonitorDataEncoder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWxvZ3N0YXNoL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tb25pdG9yL2xvZ3N0YXNoL0pzb25Nb25pdG9yRGF0YUVuY29kZXIuamF2YQ==) | `100% <100%> (ø)` | |
| [...dubbo/monitor/logstash/LogstashMonitorFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWxvZ3N0YXNoL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tb25pdG9yL2xvZ3N0YXNoL0xvZ3N0YXNoTW9uaXRvckZhY3RvcnkuamF2YQ==) | `100% <100%> (ø)` | |
| [...apache/dubbo/monitor/logstash/LogstashMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWxvZ3N0YXNoL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tb25pdG9yL2xvZ3N0YXNoL0xvZ3N0YXNoTW9uaXRvci5qYXZh) | `62.42% <62.42%> (ø)` | |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `60.86% <0%> (-6.53%)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `64.1% <0%> (-5.13%)` | :arrow_down: |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `67.85% <0%> (-3.58%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3009/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3009?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3009?src=pr&el=footer). Last update [df219f3...bb6618a](https://codecov.io/gh/apache/incubator-dubbo/pull/3009?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3009 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] dubbo-bot commented on issue #3009: Add
dubbo-monitor-logstash
Posted by "dubbo-bot (GitHub)" <gi...@apache.org>.
Ping @biyuhao . Conflict happens after merging a previous commit. Please rebase the branch against master and push it back again. Thanks a lot.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3009 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] nzomkxia commented on issue #3009: Add
dubbo-monitor-logstash
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
I want to add dubbo metrics feature and use it to implement dubbo monitor, maybe we can have some discussion?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3009 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org