You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2008/12/16 14:50:08 UTC
DO NOT REPLY [Bug 46406] New: Supporting relative paths in
isapi_redirect.properties.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46406
Summary: Supporting relative paths in isapi_redirect.properties.
Product: Tomcat Connectors
Version: 1.2.27
Platform: PC
OS/Version: Windows Server 2003
Status: NEW
Severity: enhancement
Priority: P2
Component: isapi
AssignedTo: dev@tomcat.apache.org
ReportedBy: ealvarez@motionpoint.com
Created an attachment (id=23030)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23030)
Updated version of jk_isapi_plugin.c
I have several hundred instances of Tomcat using the IIS ISAPI
redirect filter.
I updated to version 1.2.27 of the ISAPI_redirect.dll to use the new
environment variables (JKISAPI_PATH, JKISAPI_NAME) so
that I don't have to edit each property file with full file paths.
However, it appears the ISAPI filter gets confused sometimes
when it gets reloaded multiple times and writes to log files of other instances
on the same machine.
So, I would like to propose an enhancement to be able to have an
isapi_redirect.properties file with relative file paths like the following:
###############################################
# Relative path to the log file for the ISAPI Redirector
log_file=isapi_redirect.log
# Relative path to the workers.properties file
worker_file=workers.properties
# Relative path to the uriworkermap.properties file
worker_mount_file=uriworkermap.properties
###############################################
Attached is a modified version of jk_isapi_plugin.c.
The additional lines added start at line number 2630.
Existing line:
ok = ok && get_config_parameter(src, JK_LOG_FILE_TAG, log_file,
sizeof(log_file));
Added lines after 2630:
if (ok && strrchr(log_file, '\\') == NULL) {
StringCbCopy(tmpbuf, MAX_PATH, log_file);
StringCbCopy(log_file, MAX_PATH, dll_file_path);
StringCbCat(log_file, MAX_PATH, "\\");
StringCbCat(log_file, MAX_PATH, tmpbuf);
}
Existing line:
ok = ok && get_config_parameter(src, JK_WORKER_FILE_TAG, worker_file,
sizeof(worker_file));
Additional lines added after above line:
if (ok && strrchr(worker_file, '\\') == NULL) {
StringCbCopy(tmpbuf, MAX_PATH, worker_file);
StringCbCopy(worker_file, MAX_PATH, dll_file_path);
StringCbCat(worker_file, MAX_PATH, "\\");
StringCbCat(worker_file, MAX_PATH, tmpbuf);
}
Existing line:
ok = ok && get_config_parameter(src, JK_MOUNT_FILE_TAG, worker_mount_file,
sizeof(worker_mount_file));
Additional lines added after above line:
if (ok && strrchr(worker_mount_file, '\\') == NULL) {
StringCbCopy(tmpbuf, MAX_PATH, worker_mount_file);
StringCbCopy(worker_mount_file, MAX_PATH, dll_file_path);
StringCbCat(worker_mount_file, MAX_PATH, "\\");
StringCbCat(worker_mount_file, MAX_PATH, tmpbuf);
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 46406] Supporting relative paths in
isapi_redirect.properties.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46406
Mladen Turk <mt...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #1 from Mladen Turk <mt...@apache.org> 2011-11-08 13:42:17 UTC ---
Fixed in the trunk.
I implemented a 'proper' relative path system which calculates
relative paths from the isapi_redirect.dll location using a
standard directory traversal notation (..\..\..)
So the things like
worker_properties=..\conf\worker.properties
should work now.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org