You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Sean Owen <sr...@gmail.com> on 2018/11/06 13:44:23 UTC
Removing non-deprecated R methods that were deprecated in Python, Scala?
See https://github.com/apache/spark/pull/22921#discussion_r230568058
Methods like toDegrees, toRadians, approxCountDistinct were 'renamed'
in Spark 2.1: deprecated, and replaced with an identical method with
different name. However, these weren't actually deprecated in SparkR.
Is it an oversight that we should just correct anyway by removing, to
stay synced?
Or deprecate and retain these in Spark 3.0.0?
Sean
---------------------------------------------------------------------
To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
Re: Removing non-deprecated R methods that were deprecated in Python, Scala?
Posted by Shivaram Venkataraman <sh...@eecs.berkeley.edu>.
Yep. That sounds good to me.
On Tue, Nov 6, 2018 at 11:06 AM Sean Owen <sr...@gmail.com> wrote:
>
> Sounds good, remove in 3.1? I can update accordingly.
>
> On Tue, Nov 6, 2018, 10:46 AM Reynold Xin <rxin@databricks.com wrote:
>>
>> Maybe deprecate and remove in next version? It is bad to just remove a method without deprecation notice.
>>
>> On Tue, Nov 6, 2018 at 5:44 AM Sean Owen <sr...@gmail.com> wrote:
>>>
>>> See https://github.com/apache/spark/pull/22921#discussion_r230568058
>>>
>>> Methods like toDegrees, toRadians, approxCountDistinct were 'renamed'
>>> in Spark 2.1: deprecated, and replaced with an identical method with
>>> different name. However, these weren't actually deprecated in SparkR.
>>>
>>> Is it an oversight that we should just correct anyway by removing, to
>>> stay synced?
>>> Or deprecate and retain these in Spark 3.0.0?
>>>
>>> Sean
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>>
---------------------------------------------------------------------
To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
Re: Removing non-deprecated R methods that were deprecated in Python, Scala?
Posted by Sean Owen <sr...@gmail.com>.
Sounds good, remove in 3.1? I can update accordingly.
On Tue, Nov 6, 2018, 10:46 AM Reynold Xin <rxin@databricks.com wrote:
> Maybe deprecate and remove in next version? It is bad to just remove a
> method without deprecation notice.
>
> On Tue, Nov 6, 2018 at 5:44 AM Sean Owen <sr...@gmail.com> wrote:
>
>> See https://github.com/apache/spark/pull/22921#discussion_r230568058
>>
>> Methods like toDegrees, toRadians, approxCountDistinct were 'renamed'
>> in Spark 2.1: deprecated, and replaced with an identical method with
>> different name. However, these weren't actually deprecated in SparkR.
>>
>> Is it an oversight that we should just correct anyway by removing, to
>> stay synced?
>> Or deprecate and retain these in Spark 3.0.0?
>>
>> Sean
>>
>> ---------------------------------------------------------------------
>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>
>>
Re: Removing non-deprecated R methods that were deprecated in Python, Scala?
Posted by Reynold Xin <rx...@databricks.com>.
Maybe deprecate and remove in next version? It is bad to just remove a
method without deprecation notice.
On Tue, Nov 6, 2018 at 5:44 AM Sean Owen <sr...@gmail.com> wrote:
> See https://github.com/apache/spark/pull/22921#discussion_r230568058
>
> Methods like toDegrees, toRadians, approxCountDistinct were 'renamed'
> in Spark 2.1: deprecated, and replaced with an identical method with
> different name. However, these weren't actually deprecated in SparkR.
>
> Is it an oversight that we should just correct anyway by removing, to
> stay synced?
> Or deprecate and retain these in Spark 3.0.0?
>
> Sean
>
> ---------------------------------------------------------------------
> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>
>