You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2014/03/10 04:34:27 UTC

[3/5] git commit: Fix "updating" message being cleared only on success.

Fix "updating" message being cleared only on success.


Project: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/commit/584de8e0
Tree: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/tree/584de8e0
Diff: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/diff/584de8e0

Branch: refs/heads/master
Commit: 584de8e026cf5345c743509bdce172558f18f92d
Parents: be0b7a9
Author: Andrew Grieve <ag...@chromium.org>
Authored: Sun Mar 9 22:57:20 2014 -0400
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Sun Mar 9 22:57:20 2014 -0400

----------------------------------------------------------------------
 www/cdvah/js/Installer.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-app-harness/blob/584de8e0/www/cdvah/js/Installer.js
----------------------------------------------------------------------
diff --git a/www/cdvah/js/Installer.js b/www/cdvah/js/Installer.js
index 54c1b40..dc9ee04 100644
--- a/www/cdvah/js/Installer.js
+++ b/www/cdvah/js/Installer.js
@@ -67,7 +67,6 @@
             return this.doUpdateApp()
             .then(function() {
                 self.lastUpdated = new Date();
-                self.updatingStatus = null;
                 if (self.type === 'crx') {
                     // No cordova_plugins.js to read for .crx-based apps.
                     return $q.when({});
@@ -78,6 +77,8 @@
                 self.updatingStatus = Math.round(status * 100);
             }).then(function(metadata) {
                 self.plugins = PluginMetadata.process(metadata);
+            }).finally(function() {
+                self.updatingStatus = null;
             });
         };