You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/21 10:30:07 UTC
[GitHub] [shardingsphere] hitnewbee edited a comment on issue #4784: Throw NPE when INSERT column and values mismatch
hitnewbee edited a comment on issue #4784:
URL: https://github.com/apache/shardingsphere/issues/4784#issuecomment-632010619
I have add a judge code right after sqlstatement has been instantiated, with serveral test seem like it works for this issue. I think better way maybe :
1.make a judement method in CommonSQLStatementContext with default logic like return true directly;
2.if some subclass of CommonSQLStatementContext want to make their own judge method then override it.
I am not sure whether it will be a better way or not.
plz give me some advice. @menghaoranss
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org