You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/26 02:10:02 UTC

[GitHub] [zookeeper] maoling commented on a change in pull request #1194: ZOOKEEPER-3659 Make WatchManagerFactory log more readable

maoling commented on a change in pull request #1194: ZOOKEEPER-3659 Make WatchManagerFactory log more readable
URL: https://github.com/apache/zookeeper/pull/1194#discussion_r361351300
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManagerFactory.java
 ##########
 @@ -32,14 +32,14 @@
 
     public static final String ZOOKEEPER_WATCH_MANAGER_NAME = "zookeeper.watchManagerName";
 
-    public static IWatchManager createWatchManager() throws IOException {
+    public static IWatchManager createWatchManager(String watchers) throws IOException {
         String watchManagerName = System.getProperty(ZOOKEEPER_WATCH_MANAGER_NAME);
 
 Review comment:
   `watchName` is better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services