[GitHub] [incubator-nuttx] curuvar commented on a diff in pull request #6615: Add I2C slave mode for RP2040

[GitBox <gi...@apache.org>]

curuvar commented on code in PR #6615:
URL: https://github.com/apache/incubator-nuttx/pull/6615#discussion_r922090217


##########
include/nuttx/i2c/i2c_slave.h:
##########
@@ -164,6 +208,8 @@ struct i2c_slaveops_s
         int buflen);
   int (*registercallback)(FAR struct i2c_slave_s *dev,
         int (*callback)(FAR void *arg), FAR void *arg);
+  int (*registercallback_len)(FAR struct i2c_slave_s *dev,
+        int (*callback_len)(FAR void *arg, size_t rx_len), FAR void *arg);

Review Comment:
   I would have preferred to update the original registercallback with a length parameter, but that would have broken any existing program based on the original.  I did not want to change existing API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org