You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yinxusen <gi...@git.apache.org> on 2015/11/14 12:13:16 UTC

[GitHub] spark pull request: [SPARK-11728] Replace example code in ml-ensem...

GitHub user yinxusen opened a pull request:

    https://github.com/apache/spark/pull/9716

    [SPARK-11728] Replace example code in ml-ensembles.md using include_example

    JIRA issue https://issues.apache.org/jira/browse/SPARK-11728.
    
    The ml-ensembles.md file contains `OneVsRestExample`. Instead of writing new code files of two `OneVsRestExample`s, I use two existing files in the examples directory, they are `OneVsRestExample.scala` and `JavaOneVsRestExample.scala`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yinxusen/spark SPARK-11728

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9716
    
----
commit 09891837add484908ea4ab02bca98a3d50e16e8b
Author: Xusen Yin <yi...@gmail.com>
Date:   2015-11-14T07:55:36Z

    add scala code.

commit 55a83580603cfda10258d0c63593b7fb812e321f
Author: Xusen Yin <yi...@gmail.com>
Date:   2015-11-14T08:37:18Z

    add java version

commit 985801ee15a4a09a91eee3fd3fb99cff9a5f5beb
Author: Xusen Yin <yi...@gmail.com>
Date:   2015-11-14T08:51:48Z

    add python version

commit 0e5966db5870cef8af38a655a62aca336e494c1f
Author: Xusen Yin <yi...@gmail.com>
Date:   2015-11-14T09:12:09Z

    modify markdown

commit 5b545d76abd7765183806862bc99406ba70ee42a
Author: Xusen Yin <yi...@gmail.com>
Date:   2015-11-14T10:13:44Z

    add sc stop

commit c3e96b9c53164371646981627ac58fda93d27129
Author: Xusen Yin <yi...@gmail.com>
Date:   2015-11-14T11:02:10Z

    fix python version errors

commit 9ba1d4ac38ead86d8a8631934f4e72f4df80ea96
Author: Xusen Yin <yi...@gmail.com>
Date:   2015-11-14T11:09:42Z

    fix python style

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11728] Replace example code in ml-ensem...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9716#issuecomment-156689964
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45929/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11728] Replace example code in ml-ensem...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9716#issuecomment-156689963
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11728] Replace example code in ml-ensem...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9716#issuecomment-156687789
  
    **[Test build #45929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45929/consoleFull)** for PR 9716 at commit [`9ba1d4a`](https://github.com/apache/spark/commit/9ba1d4ac38ead86d8a8631934f4e72f4df80ea96).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-11728] Replace example code in ml-ensem...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9716#issuecomment-156689941
  
    **[Test build #45929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45929/consoleFull)** for PR 9716 at commit [`9ba1d4a`](https://github.com/apache/spark/commit/9ba1d4ac38ead86d8a8631934f4e72f4df80ea96).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:\n  * `public class JavaGradientBoostedTreeClassifierExample `\n  * `public class JavaGradientBoostedTreeRegressorExample `\n  * `public class JavaRandomForestClassifierExample `\n  * `public class JavaRandomForestRegressorExample `\n


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org