svn commit: r1891623 - /pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java

[ti...@apache.org]

Author: tilman
Date: Sat Jul 17 18:05:35 2021
New Revision: 1891623

URL: http://svn.apache.org/viewvc?rev=1891623&view=rev
Log:
PDFBOX-4892: optimize + fix javadoc, as suggested by valerybokov

Modified:
    pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java

Modified: pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java?rev=1891623&r1=1891622&r2=1891623&view=diff
==============================================================================
--- pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java (original)
+++ pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java Sat Jul 17 18:05:35 2021
@@ -128,12 +128,15 @@ public class CMap
                 bytes[byteCount] = (byte)in.read();
             }
         }
-        String seq = "";
-        for (int i = 0; i < maxCodeLength; ++i)
+        if (LOG.isWarnEnabled())
         {
-            seq += String.format("0x%02X (%04o) ", bytes[i], bytes[i]);
+            StringBuilder sb = new StringBuilder();
+            for (int i = 0; i < maxCodeLength; ++i)
+            {
+                sb.append(String.format("0x%02X (%04o) ", bytes[i], bytes[i]));
+            }
+            LOG.warn("Invalid character code sequence " + sb + "in CMap " + cmapName);
         }
-        LOG.warn("Invalid character code sequence " + seq + "in CMap " + cmapName);
         // PDFBOX-4811 reposition to where we were after initial read
         if (in.markSupported())
         {
@@ -225,7 +228,7 @@ public class CMap
     /**
      * Get the code bytes for an unicode string.
      *
-     * @param unicode
+     * @param unicode The unicode string.
      * @return the code bytes or null if there is none.
      */
     public byte[] getCodesFromUnicode(String unicode)