You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by "snoopdave (via GitHub)" <gi...@apache.org> on 2026/09/07 17:01:06 UTC

[PR] Use double-quoted href attributes on the comment management page [roller]

snoopdave opened a new pull request, #181:
URL: https://github.com/apache/roller/pull/181

   The links on the comment management screen (Comments.jsp) wrapped their `<s:property/>` URL values in single-quoted `href` attributes. This switches them to double-quoted attributes, matching the convention already used for URL-valued attributes elsewhere in the authoring UI — for example the bookmark URL in `Bookmarks.jsp` — so externally supplied URL values stay contained within the attribute.
   
   A rule is added to `AuthoringUiSinkAuditTest` asserting that the comment author URL renders inside a double-quoted `href`, keeping the convention going forward.
   
   Full `app` test suite green on JDK 11 (298 tests).
   
   https://claude.ai/code/session_015X69HHQ5XnjRkJP8ymzwFf


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use double-quoted href attributes on the comment management page [roller]

Posted by "snoopdave (via GitHub)" <gi...@apache.org>.
snoopdave merged PR #181:
URL: https://github.com/apache/roller/pull/181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org