You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2020/03/09 09:45:29 UTC
[GitHub] [incubator-teaclave] sammyne opened a new pull request #233:
docs(attestation): fix a typo and add some doc
sammyne opened a new pull request #233: docs(attestation): fix a typo and add some doc
URL: https://github.com/apache/incubator-teaclave/pull/233
## Description
The built-in ECDSA is based on NIST P-256 (a.k.a. secp256r1), not secp256k1. This PR just fix that typo~
Relevant line of codes is https://github.com/apache/incubator-teaclave/blob/develop/attestation/src/key.rs#L25
## Type of change (select applied and DELETE the others)
- API change with a documentation update
## How Has This Been Tested?
Document changed only~
## Checklist (check ALL before submitting PR, even not applicable)
- [x] Fork the repo and create your branch from `master`.
- [x] If you've added code that should be tested, add tests.
- [x] If you've changed APIs, update the documentation.
- [x] Ensure the tests pass (see CI results).
- [x] Make sure your code lints/format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun merged pull request #233:
docs(attestation): fix a typo and add some doc
Posted by GitBox <gi...@apache.org>.
mssun merged pull request #233: docs(attestation): fix a typo and add some doc
URL: https://github.com/apache/incubator-teaclave/pull/233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun commented on issue #233:
docs(attestation): fix a typo and add some doc
Posted by GitBox <gi...@apache.org>.
mssun commented on issue #233: docs(attestation): fix a typo and add some doc
URL: https://github.com/apache/incubator-teaclave/pull/233#issuecomment-596621972
Nice catch. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org