You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/07/19 03:59:03 UTC

[GitHub] [incubator-eventmesh] SteveYurongSu commented on pull request #443: [ISSUE #442] Fix findings filtered by Checkstyle workflow

SteveYurongSu commented on pull request #443:
URL: https://github.com/apache/incubator-eventmesh/pull/443#issuecomment-882215040


   > LGTM, When I submitted a pr, I found that the file `sChat2.jks` seems to break the rules in checkStyle, do we need to exclude this file? I am not sure whether this will happen.
   
   @ruanwenjun Thanks for reviewing! 
   
   I have the same question. It seems that `sChat2.jks` is an unexpected binary file, should we remove the file? @qqeasonchen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org