You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Sqoop QA bot (JIRA)" <ji...@apache.org> on 2015/12/24 07:54:49 UTC
[jira] [Commented] (SQOOP-2546) Sqoop2: RESTiliency: Unify behavior
on getting details on non-existing connector
[ https://issues.apache.org/jira/browse/SQOOP-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070665#comment-15070665 ]
Sqoop QA bot commented on SQOOP-2546:
-------------------------------------
Testing file [SQOOP-2546.001.patch|https://issues.apache.org/jira/secure/attachment/12779386/SQOOP-2546.001.patch] against branch sqoop2 took 1:09:18.620623.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1648 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/2042/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/2042/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 147 tests)
Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/2042/console].
This message is automatically generated.
> Sqoop2: RESTiliency: Unify behavior on getting details on non-existing connector
> --------------------------------------------------------------------------------
>
> Key: SQOOP-2546
> URL: https://issues.apache.org/jira/browse/SQOOP-2546
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Jarek Jarcec Cecho
> Assignee: Colin Ma
> Fix For: 1.99.7
>
> Attachments: SQOOP-2546.001.patch
>
>
> Here is test code that is testing our behavior on non existing connector:
> {code}
> new TestDescription("Get connector by non-existing ID", "v1/connector/666", "GET", null, new Validator() {
> @Override
> void validate() throws Exception {
> assertResponseCode(500);
> assertServerException("org.apache.sqoop.error.code.CommonRepositoryError", "COMMON_0057");
> }}),
> new TestDescription("Get connector by non-existing name", "v1/connector/jarcecs-cool-connector", "GET", null, new Validator() {
> @Override
> void validate() throws Exception {
> assertResponseCode(500);
> assertServerException("org.apache.sqoop.server.common.ServerError", "SERVER_0005");
> }}),
> {code}
> Depending whether one asks for non-existing connector ID or non-existing connector name, he gets different answer. That seems really weird for single REST end point and I think that we should fix that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)