You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/12/13 15:36:46 UTC
[GitHub] [ozone] rakeshadr commented on pull request #2915: HDDS-6089. Remove OMClientResponse#getBucketLayout override in subclasses - part2
rakeshadr commented on pull request #2915:
URL: https://github.com/apache/ozone/pull/2915#issuecomment-992600303
@JyotinderSingh thanks for the patch. Overall the changes looks good. Adding few comments.
**Point-1)** There is one more constructor in *ResponseWithFSO classes to be considered. You need to pass BucketLayout argument here as well. This constructor is used in the error case and mostly doing log info. Below are some of the classes, please check all the *ResponseWithFSO constructors and ensure all are initialized with correct bucket layout.
```
public OMAllocateBlockResponseWithFSO(@Nonnull OMResponse omResponse) {
public OMKeyCommitResponseWithFSO(@Nonnull OMResponse omResponse) {
public OMKeyCreateResponseWithFSO(@Nonnull OMResponse omResponse) {
public OMKeyDeleteResponseWithFSO(@Nonnull OMResponse omResponse) {
public OMKeyRenameResponseWithFSO(@Nonnull OMResponse omResponse) {
public OMFileCreateResponseWithFSO(@Nonnull OMResponse omResponse) {
```
Point-2) Please extend `OMDirectoryCreateResponseWithFSO extends OmKeyResponse` and `OMDirectoryCreateResponse extends OmKeyResponse`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org