You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Vjacheslav Kanivetc (JIRA)" <ji...@apache.org> on 2008/11/26 09:10:44 UTC

[jira] Commented: (WICKET-1957) Odd number of page parameters - should not throw IllegalStateException

    [ https://issues.apache.org/jira/browse/WICKET-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650892#action_12650892 ] 

Vjacheslav Kanivetc commented on WICKET-1957:
---------------------------------------------

Yes, this is a very annoying behavior in 1.3 series of wicket as well, especially when we wish to allow people to modify url, for example, for username and password-protected rss with some extra parameters, the way like BookmarkablePageRequestTargetUrlCodingStrategy encodes the input, user is unable to enter for example /username/password/somemask, he needs to enter pairs of key-value.

Much better would be to simply pass resulting PageParameters to the handler that is going to accept the input

> Odd number of page parameters - should not throw IllegalStateException
> ----------------------------------------------------------------------
>
>                 Key: WICKET-1957
>                 URL: https://issues.apache.org/jira/browse/WICKET-1957
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.4-RC1
>            Reporter: Stefan Simik
>
> The default URL strategy in wicket throws IllegalStateException, when there is odd number of parameters ?
> See AbstractRequestTargetUrlCodingStrategy: line 169 in RC1
> We have a problem with this way handling, because our users rewrite URLs manually
> (we cannot prevent users from doing this).
> Our pages are stateless and they don't use any parameters - BUT there are throwing exceptions
> and showing InternalErrorPage-s. It is presented like a serious problem like DB, or like service failed
> but there is no problem actually - only parameters, that are not used.
> I think, that page parameters should not result in INTERNAL ERROR,
> because there are many cases, where this is not relevant.
> There should be an alternative way - some custom handling or ignoring parameters in such a situation.
> The same problem is with MixedParamUrlCodingStrategy:
> (See MixedParamUrlCodingStrategy: line 181)  in RC1
> ------------------------------------------------------------------------------------
> Adding additional parameter results in exception a internal-error page.
> IMHO, additional parameters should be ignored and not result in error.
> I would suggest add the latest odd parameter to page parameters, but with empty value "".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.