You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/09/30 12:44:26 UTC
[commons-compress] branch master updated: Better parameter names
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
The following commit(s) were added to refs/heads/master by this push:
new 3d8f48fa Better parameter names
3d8f48fa is described below
commit 3d8f48fa805df3857270803806a0a1d2d9f43a31
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Sep 30 08:44:21 2022 -0400
Better parameter names
---
.../compress/harmony/pack200/NewAttributeBands.java | 16 ++++++++--------
.../harmony/unpack200/tests/Compress626Test.java | 2 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java b/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java
index d5bd9176..099987ce 100644
--- a/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java
+++ b/src/main/java/org/apache/commons/compress/harmony/pack200/NewAttributeBands.java
@@ -781,15 +781,15 @@ public class NewAttributeBands extends BandSet {
* Utility method to get the contents of the given stream, up to the next ']', (ignoring pairs of brackets '[' and
* ']')
*
- * @param stream
+ * @param reader
* @return
* @throws IOException If an I/O error occurs.
*/
- private StringReader getStreamUpToMatchingBracket(final StringReader stream) throws IOException {
+ private StringReader getStreamUpToMatchingBracket(final StringReader reader) throws IOException {
final StringBuilder sb = new StringBuilder();
int foundBracket = -1;
while (foundBracket != 0) {
- final char c = (char) stream.read();
+ final char c = (char) reader.read();
if (c == ']') {
foundBracket++;
}
@@ -803,11 +803,11 @@ public class NewAttributeBands extends BandSet {
return new StringReader(sb.toString());
}
- private int readInteger(final int i, final InputStream stream) {
+ private int readInteger(final int i, final InputStream inputStream) {
int result = 0;
for (int j = 0; j < i; j++) {
try {
- result = result << 8 | stream.read();
+ result = result << 8 | inputStream.read();
} catch (final IOException e) {
throw new UncheckedIOException("Error reading unknown attribute", e);
}
@@ -848,15 +848,15 @@ public class NewAttributeBands extends BandSet {
* Utility method to get the contents of the given stream, up to the next ']', (ignoring pairs of brackets '[' and
* ']')
*
- * @param stream
+ * @param reader
* @return
* @throws IOException If an I/O error occurs.
*/
- private String readUpToMatchingBracket(final StringReader stream) throws IOException {
+ private String readUpToMatchingBracket(final StringReader reader) throws IOException {
final StringBuilder sb = new StringBuilder();
int foundBracket = -1;
while (foundBracket != 0) {
- final char c = (char) stream.read();
+ final char c = (char) reader.read();
if (c == ']') {
foundBracket++;
}
diff --git a/src/test/java/org/apache/commons/compress/harmony/unpack200/tests/Compress626Test.java b/src/test/java/org/apache/commons/compress/harmony/unpack200/tests/Compress626Test.java
index 690cb6ef..ba475da1 100644
--- a/src/test/java/org/apache/commons/compress/harmony/unpack200/tests/Compress626Test.java
+++ b/src/test/java/org/apache/commons/compress/harmony/unpack200/tests/Compress626Test.java
@@ -32,7 +32,7 @@ import org.junit.Ignore;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
-@Disabled @Ignore
+//@Disabled @Ignore
public class Compress626Test {
@Test