You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by pr...@apache.org on 2017/03/03 12:04:01 UTC
zeppelin git commit: [ZEPPELIN-2113] Remove border and margin of Link
this paragraph window
Repository: zeppelin
Updated Branches:
refs/heads/master d294a765a -> fb4c778b9
[ZEPPELIN-2113] Remove border and margin of Link this paragraph window
### What is this PR for?
This PR is for removing border and margin of paragraph shape in new window which is created by "Link this paragraph" operation.
It would be nice and neat to be removed such like that is suggested at [this comment](https://github.com/apache/zeppelin/pull/1983#issuecomment-279395050).
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2113](https://issues.apache.org/jira/browse/ZEPPELIN-2113)
### How should this be tested?
1. Click `Link this paragraph`
2. Check a paragraph shape
### Screenshots (if appropriate)
[ Before ]
[ After ]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: soralee <so...@zepl.com>
Closes #2054 from soralee/ZEPPELIN-2113_remove_border_margin and squashes the following commits:
e47cc57 [soralee] remove border and margin
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/fb4c778b
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/fb4c778b
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/fb4c778b
Branch: refs/heads/master
Commit: fb4c778b9e841004d0d884566b670826c6ff29dc
Parents: d294a76
Author: soralee <so...@zepl.com>
Authored: Wed Feb 22 13:41:31 2017 +0900
Committer: Prabhjyot Singh <pr...@gmail.com>
Committed: Fri Mar 3 17:33:55 2017 +0530
----------------------------------------------------------------------
zeppelin-web/src/app/home/home.css | 1 +
zeppelin-web/src/app/home/home.html | 2 +-
zeppelin-web/src/app/notebook/notebook.html | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4c778b/zeppelin-web/src/app/home/home.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/home/home.css b/zeppelin-web/src/app/home/home.css
index a0e4a6d..f813ccc 100644
--- a/zeppelin-web/src/app/home/home.css
+++ b/zeppelin-web/src/app/home/home.css
@@ -28,6 +28,7 @@ body {
}
.bodyAsIframe {
+ padding-top: 20px;
background: white;
}
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4c778b/zeppelin-web/src/app/home/home.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/home/home.html b/zeppelin-web/src/app/home/home.html
index b86671d..04a85cd 100644
--- a/zeppelin-web/src/app/home/home.html
+++ b/zeppelin-web/src/app/home/home.html
@@ -82,7 +82,7 @@ limitations under the License.
ng-controller="ParagraphCtrl"
ng-init="init(currentParagraph, home.note)"
ng-class="columnWidthClass(currentParagraph.config.colWidth)"
- class="paragraph-col">
+ style="margin: 0; padding: 0;">
<div id="{{currentParagraph.id}}_paragraphColumn"
ng-if="currentParagraph.results"
ng-include src="'app/notebook/paragraph/paragraph.html'"
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fb4c778b/zeppelin-web/src/app/notebook/notebook.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook.html b/zeppelin-web/src/app/notebook/notebook.html
index 303a1f0..42c2310 100644
--- a/zeppelin-web/src/app/notebook/notebook.html
+++ b/zeppelin-web/src/app/notebook/notebook.html
@@ -112,7 +112,7 @@ limitations under the License.
ng-controller="ParagraphCtrl"
ng-init="init(currentParagraph, note)"
ng-class="columnWidthClass(currentParagraph.config.colWidth)"
- class="paragraph-col">
+ style="margin: 0; padding: 0;">
<div class="new-paragraph" ng-click="insertNew('above')" ng-hide="viewOnly || asIframe || revisionView">
<h4 class="plus-sign">+</h4>
</div>