[GitHub] fmaximus commented on a change in pull request #2688: CLOUDSTACK-10382: Fix cloud-get-vm-data-configdrive.in

[GitBox <gi...@apache.org>]

fmaximus commented on a change in pull request #2688: CLOUDSTACK-10382: Fix cloud-get-vm-data-configdrive.in
URL: https://github.com/apache/cloudstack/pull/2688#discussion_r193008730
 
 

 ##########
 File path: setup/bindir/cloud-get-vm-data-configdrive.in
 ##########
 @@ -21,23 +21,28 @@ mountdir=$(mktemp -d)
 filepath=$mountdir/cloudstack
 
 user_data=$filepath/userdata/user_data.txt
-availability_zone=$filepath/metadata/availability_zone.txt
 
 Review comment:
   The original script was only working under bash as well. function is a keyword unknown in `sh`.
   As specified in the description, the changes require Bash 4.
   I can also add a version specifically for bash 3, but I suppose with shellshock most people will have upgraded to bash 4 by now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services