You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/04/05 15:04:09 UTC

[GitHub] [rocketmq-client-cpp] jonnxu opened a new pull request #129: Resolve crash, test cash error and compile warning for unit test cash

jonnxu opened a new pull request #129: Resolve crash, test cash error and compile warning for unit test cash
URL: https://github.com/apache/rocketmq-client-cpp/pull/129
 
 
   ## What is the purpose of the change
   
   crash, test cash error and compile warning for unit test cash
   
   ## Brief changelog
   
   set the chang files: test/src/*
   
   ## Verifying this change
   
   ##################  test  start  ###########
   BatchMessageTest success
   big_endianTest success
   ClientRemotingProcessorTest success
   ClientRPCHookTest success
   CMessageExtTest success
   CMessageTest success
   CommandHeaderTest success
   ConsumerRunningInfoTest success
   CProducerTest success
   CPullConsumerTest success
   CPushConsumerTest success
   HeartbeatDataTest success
   KVTableTest success
   LockBatchBodyTest success
   MemoryBlockTest success
   MemoryOutputStreamTest success
   MessageQueueTest success
   MQDecoderTest success
   MQMessageExtTest success
   MQMessageIdTest success
   MQMessageQueueTest success
   MQMessageTest success
   NamesrvConfigTest success
   PermNametTest success
   ProcessQueueInfoTest success
   PullSysFlagTest success
   RemotingCommandTest success
   ResponseFutureTest success
   SocketUtilTest success
   StringIdMakerTest success
   TopicConfigTest success
   TopicRouteDataTest success
   UrlTest success
   ValidatorsTest success
   VirtualEnvUtilTest success
   ##################  test  end  ###########
   
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services