You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/17 19:10:45 UTC

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5209: Perlectomy

zrhoffman commented on a change in pull request #5209:
URL: https://github.com/apache/trafficcontrol/pull/5209#discussion_r577871469



##########
File path: infrastructure/cdn-in-a-box/optional/docker-compose.debugging.yml
##########
@@ -81,16 +72,6 @@ services:
       args:

Review comment:
       The context needs to be `../..` now

##########
File path: infrastructure/cdn-in-a-box/optional/docker-compose.debugging.yml
##########
@@ -39,15 +39,6 @@ services:
       - "2345:2345" #Delve debugging port
     depends_on:
       - trafficops-go-nondebug

Review comment:
       The `-go` in `Dockerfile-go-debug`, `trafficops-go-debug`, and and `trafficops-go-nondebug` can be removed.

##########
File path: infrastructure/cdn-in-a-box/optional/docker-compose.debugging.yml
##########
@@ -81,16 +72,6 @@ services:
       args:

Review comment:
       Same as above: The `-go` in `trafficops-go-nondebug`, `trafficops-go`, `trafficops-go-debug`, and `Dockerfile-go` can be removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org