You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/06 10:54:04 UTC
[GitHub] [arrow] alamb opened a new pull request #9904: ARROW-12224: [Rust] Use stable rust for no default test, clean up CI tests
alamb opened a new pull request #9904:
URL: https://github.com/apache/arrow/pull/9904
# Rationale
1. As @jorgecarleitao noted on https://github.com/apache/arrow/pull/9889#discussion_r607720790, we should be running the check if arrow compiles with stable rust as that is what we target for the arrow crate
2. I noticed that there were several redundant (and inconsistent) settings of `RUSTFLAGS`
3. The titles of many of the tests are confusing (to me) as they have a lot of detailed architecture / rust version information before the description of what they are testing
# Changes
1. Use rust stable for the check that ensures the crate builds without default features
2. Remove redundant `RUSTFLAGS`
3. Change titles of the jobs to consistently start with a description of what they do
# Note
This could be three individual PRs, but I wanted to avoid the overhead of three separate JIRA tickets and juggling several concurrent potentially conflicting PRs. I will break it into three individual ones however if reviewers want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9904: ARROW-12224: [Rust] Use stable rust for no default test, clean up CI tests
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9904:
URL: https://github.com/apache/arrow/pull/9904#discussion_r608879085
##########
File path: .github/workflows/rust.yml
##########
@@ -33,7 +33,7 @@ jobs:
# build the library, a compilation step used by multiple steps below
linux-build-lib:
- name: AMD64 Debian 10 Rust ${{ matrix.rust }} build libraries
Review comment:
Thanks for the hint @jorgecarleitao -- will wait for @kszucs to weigh in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9904: ARROW-12224: [Rust] Use stable rust for no default test, clean up CI tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9904:
URL: https://github.com/apache/arrow/pull/9904#issuecomment-814027169
https://issues.apache.org/jira/browse/ARROW-12224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #9904: ARROW-12224: [Rust] Use stable rust for no default test, clean up CI tests
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #9904:
URL: https://github.com/apache/arrow/pull/9904#discussion_r608943306
##########
File path: .github/workflows/rust.yml
##########
@@ -33,7 +33,7 @@ jobs:
# build the library, a compilation step used by multiple steps below
linux-build-lib:
- name: AMD64 Debian 10 Rust ${{ matrix.rust }} build libraries
Review comment:
I prefer this convention to remain consistent with the rest of the workflows (C++, Python, Ruby, etc.).
I'm fine with using a different naming convention too if you think that helps distinguishing the builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9904: ARROW-12224: [Rust] Use stable rust for no default test, clean up CI tests
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9904:
URL: https://github.com/apache/arrow/pull/9904#discussion_r609095168
##########
File path: .github/workflows/rust.yml
##########
@@ -33,7 +33,7 @@ jobs:
# build the library, a compilation step used by multiple steps below
linux-build-lib:
- name: AMD64 Debian 10 Rust ${{ matrix.rust }} build libraries
Review comment:
I think it will help. Let's try this way and see how we like it. Thanks @kszucs 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9904: ARROW-12224: [Rust] Use stable rust for no default test, clean up CI tests
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9904:
URL: https://github.com/apache/arrow/pull/9904#issuecomment-814043406
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9904?src=pr&el=h1) Report
> Merging [#9904](https://codecov.io/gh/apache/arrow/pull/9904?src=pr&el=desc) (dad8209) into [master](https://codecov.io/gh/apache/arrow/commit/dd8cd10d9f4ac57f01ca500488f89fa67c2a43e4?el=desc) (dd8cd10) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9904?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9904 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 256 256
Lines 60186 60186
=======================================
Hits 49780 49780
Misses 10406 10406
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9904?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9904?src=pr&el=footer). Last update [dd8cd10...dad8209](https://codecov.io/gh/apache/arrow/pull/9904?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9904: ARROW-12224: [Rust] Use stable rust for no default test, clean up CI tests
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #9904:
URL: https://github.com/apache/arrow/pull/9904#discussion_r608837727
##########
File path: .github/workflows/rust.yml
##########
@@ -33,7 +33,7 @@ jobs:
# build the library, a compilation step used by multiple steps below
linux-build-lib:
- name: AMD64 Debian 10 Rust ${{ matrix.rust }} build libraries
Review comment:
@kszucs has raised in the past the he would prefer to have the same names as other implementations.
pinging him here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9904: ARROW-12224: [Rust] Use stable rust for no default test, clean up CI tests
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9904:
URL: https://github.com/apache/arrow/pull/9904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org