You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "William1104 (via GitHub)" <gi...@apache.org> on 2024/02/14 14:57:00 UTC

[PR] [WIP][SPARK-47042][BUILD] add missing explicit dependency 'commons-lang3' to the module 'spark-common-utils' [spark]

William1104 opened a new pull request, #45100:
URL: https://github.com/apache/spark/pull/45100

   ### What changes were proposed in this pull request?
   This PR aims to fix `spark-common-utils` module by adding explicit `commons-lang3` dependency. 
   
   ### Why are the changes needed?
   `spark-common-utils` uses `commons-lang3` like the following, but we didn't declare it explicitly. 
   
   [MavenUtils.scala](https://github.com/William1104/spark/blob/ad93dfb565ad2f6a04505365294bf1b1c603c2ce/common/utils/src/main/scala/org/apache/spark/util/MavenUtils.scala#L25)
   
   [ClosureCleaner.scala]
   (https://github.com/William1104/spark/blob/ad93dfb565ad2f6a04505365294bf1b1c603c2ce/common/utils/src/main/scala/org/apache/spark/util/ClosureCleaner.scala#L27)
   
   [JavaUtils.java]
   (https://github.com/William1104/spark/blob/ad93dfb565ad2f6a04505365294bf1b1c603c2ce/common/utils/src/main/java/org/apache/spark/network/util/JavaUtils.java#L31)
   
   ### How was this patch tested?
   Pass the CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [WIP][SPARK-47042][BUILD] add missing explicit dependency 'commons-lang3' to the module 'spark-common-utils' [spark]

Posted by "William1104 (via GitHub)" <gi...@apache.org>.
William1104 closed pull request #45100: [WIP][SPARK-47042][BUILD] add missing explicit dependency 'commons-lang3' to the module 'spark-common-utils'
URL: https://github.com/apache/spark/pull/45100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org