You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Marshall Schor (JIRA)" <ji...@codehaus.org> on 2008/02/04 18:22:57 UTC

[jira] Created: (MECLIPSE-385) version normalization from Maven to Eclipse is incorrect in some corner cases

version normalization from Maven to Eclipse is incorrect in some corner cases
-----------------------------------------------------------------------------

                 Key: MECLIPSE-385
                 URL: http://jira.codehaus.org/browse/MECLIPSE-385
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
          Components: OSGi, Manifest, PDE support
            Reporter: Marshall Schor
            Priority: Minor


The code in EclipseOSGiManifestWriter.getNormalizedVersion is incorrect in the case where there are 4 components as input to the version.  For instance, it converts 2.3.0.incubating-SNAPSHOT to 2.3.0.incubating.SNAPSHOT - this has 5 components, separated by "periods" and is invalid as an Eclipse version number; Eclipse version numbers have 4 components (maximum) where the first 3 are numeric.  See http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.pde.doc.user/guide/tasks/pde_version_qualifiers.htm

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-385) version normalization from Maven to Eclipse is incorrect in some corner cases

Posted by "Marshall Schor (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122353 ] 

Marshall Schor commented on MECLIPSE-385:
-----------------------------------------

maven-bundle-plugin doesn't have this problem - false alarm.  In my test I must have accidentally re-run the old eclipse:eclipse in a mode which updated the manifest.  Sorry for the noise.

> version normalization from Maven to Eclipse is incorrect in some corner cases
> -----------------------------------------------------------------------------
>
>                 Key: MECLIPSE-385
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-385
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: OSGi, Manifest, PDE support
>            Reporter: Marshall Schor
>            Priority: Minor
>         Attachments: patch-EclipseOSGiManifestWriterTest.txt, patch-getNormalizedVersion.txt
>
>
> The code in EclipseOSGiManifestWriter.getNormalizedVersion is incorrect in the case where there are 4 components as input to the version.  For instance, it converts 2.3.0.incubating-SNAPSHOT to 2.3.0.incubating.SNAPSHOT - this has 5 components, separated by "periods" and is invalid as an Eclipse version number; Eclipse version numbers have 4 components (maximum) where the first 3 are numeric.  See http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.pde.doc.user/guide/tasks/pde_version_qualifiers.htm

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-385) version normalization from Maven to Eclipse is incorrect in some corner cases

Posted by "Marshall Schor (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122346 ] 

Marshall Schor commented on MECLIPSE-385:
-----------------------------------------

maven-blundle-plugin has the same problem.  Can you point me to the right Class.method to patch?

> version normalization from Maven to Eclipse is incorrect in some corner cases
> -----------------------------------------------------------------------------
>
>                 Key: MECLIPSE-385
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-385
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: OSGi, Manifest, PDE support
>            Reporter: Marshall Schor
>            Priority: Minor
>         Attachments: patch-EclipseOSGiManifestWriterTest.txt, patch-getNormalizedVersion.txt
>
>
> The code in EclipseOSGiManifestWriter.getNormalizedVersion is incorrect in the case where there are 4 components as input to the version.  For instance, it converts 2.3.0.incubating-SNAPSHOT to 2.3.0.incubating.SNAPSHOT - this has 5 components, separated by "periods" and is invalid as an Eclipse version number; Eclipse version numbers have 4 components (maximum) where the first 3 are numeric.  See http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.pde.doc.user/guide/tasks/pde_version_qualifiers.htm

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-385) version normalization from Maven to Eclipse is incorrect in some corner cases

Posted by "Marshall Schor (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marshall Schor updated MECLIPSE-385:
------------------------------------

    Attachment: patch-getNormalizedVersion.txt

I grant these patches under the Apache 2.0 license. 

> version normalization from Maven to Eclipse is incorrect in some corner cases
> -----------------------------------------------------------------------------
>
>                 Key: MECLIPSE-385
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-385
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: OSGi, Manifest, PDE support
>            Reporter: Marshall Schor
>            Priority: Minor
>         Attachments: patch-getNormalizedVersion.txt
>
>
> The code in EclipseOSGiManifestWriter.getNormalizedVersion is incorrect in the case where there are 4 components as input to the version.  For instance, it converts 2.3.0.incubating-SNAPSHOT to 2.3.0.incubating.SNAPSHOT - this has 5 components, separated by "periods" and is invalid as an Eclipse version number; Eclipse version numbers have 4 components (maximum) where the first 3 are numeric.  See http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.pde.doc.user/guide/tasks/pde_version_qualifiers.htm

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-385) version normalization from Maven to Eclipse is incorrect in some corner cases

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_122303 ] 

Carlos Sanchez commented on MECLIPSE-385:
-----------------------------------------

That goal has been deprecated, please look into http://felix.apache.org/site/maven-bundle-plugin-bnd.html "Adding OSGi metadata to existing projects without changing the packaging type"


> version normalization from Maven to Eclipse is incorrect in some corner cases
> -----------------------------------------------------------------------------
>
>                 Key: MECLIPSE-385
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-385
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: OSGi, Manifest, PDE support
>            Reporter: Marshall Schor
>            Priority: Minor
>         Attachments: patch-EclipseOSGiManifestWriterTest.txt, patch-getNormalizedVersion.txt
>
>
> The code in EclipseOSGiManifestWriter.getNormalizedVersion is incorrect in the case where there are 4 components as input to the version.  For instance, it converts 2.3.0.incubating-SNAPSHOT to 2.3.0.incubating.SNAPSHOT - this has 5 components, separated by "periods" and is invalid as an Eclipse version number; Eclipse version numbers have 4 components (maximum) where the first 3 are numeric.  See http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.pde.doc.user/guide/tasks/pde_version_qualifiers.htm

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MECLIPSE-385) version normalization from Maven to Eclipse is incorrect in some corner cases

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carlos Sanchez closed MECLIPSE-385.
-----------------------------------

      Assignee: Carlos Sanchez
    Resolution: Won't Fix

> version normalization from Maven to Eclipse is incorrect in some corner cases
> -----------------------------------------------------------------------------
>
>                 Key: MECLIPSE-385
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-385
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: OSGi, Manifest, PDE support
>            Reporter: Marshall Schor
>            Assignee: Carlos Sanchez
>            Priority: Minor
>         Attachments: patch-EclipseOSGiManifestWriterTest.txt, patch-getNormalizedVersion.txt
>
>
> The code in EclipseOSGiManifestWriter.getNormalizedVersion is incorrect in the case where there are 4 components as input to the version.  For instance, it converts 2.3.0.incubating-SNAPSHOT to 2.3.0.incubating.SNAPSHOT - this has 5 components, separated by "periods" and is invalid as an Eclipse version number; Eclipse version numbers have 4 components (maximum) where the first 3 are numeric.  See http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.pde.doc.user/guide/tasks/pde_version_qualifiers.htm

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-385) version normalization from Maven to Eclipse is incorrect in some corner cases

Posted by "Marshall Schor (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marshall Schor updated MECLIPSE-385:
------------------------------------

    Attachment: patch-EclipseOSGiManifestWriterTest.txt

I grant this patch under the Apache License 2.0

> version normalization from Maven to Eclipse is incorrect in some corner cases
> -----------------------------------------------------------------------------
>
>                 Key: MECLIPSE-385
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-385
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: OSGi, Manifest, PDE support
>            Reporter: Marshall Schor
>            Priority: Minor
>         Attachments: patch-EclipseOSGiManifestWriterTest.txt, patch-getNormalizedVersion.txt
>
>
> The code in EclipseOSGiManifestWriter.getNormalizedVersion is incorrect in the case where there are 4 components as input to the version.  For instance, it converts 2.3.0.incubating-SNAPSHOT to 2.3.0.incubating.SNAPSHOT - this has 5 components, separated by "periods" and is invalid as an Eclipse version number; Eclipse version numbers have 4 components (maximum) where the first 3 are numeric.  See http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.pde.doc.user/guide/tasks/pde_version_qualifiers.htm

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira