You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/04/14 07:04:35 UTC

[jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

This commit accommodates changes to Predicates.and.toString and
PublicSuffixPatterns.EXACT.  Release notes:

https://code.google.com/p/guava-libraries/wiki/Release17
You can merge this Pull Request by running:

  git pull https://github.com/andrewgaul/jclouds guava-17-rc2

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/345

-- Commit Summary --

  * JCLOUDS-534: Upgrade to Guava 17.0-rc2

-- File Changes --

    M compute/src/test/java/org/jclouds/compute/domain/internal/TemplateBuilderImplTest.java (2)
    M core/pom.xml (2)
    M providers/softlayer/src/test/java/org/jclouds/softlayer/compute/options/SoftLayerTemplateOptionsTest.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/345.patch
https://github.com/jclouds/jclouds/pull/345.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by Andrew Phillips <no...@github.com>.

OK, something still missing in karaf:
```
features:install jclouds-dynect
java.lang.Exception: Could not start bundle mvn:org.apache.jclouds.provider/dynect/1.8.0-SNAPSHOT in feature(s) jclouds-dynect-1.8.0-SNAPSHOT: Unresolved constraint in bundle dynect [85]: Unable to resolve 85.0: missing requirement [85.0] osgi.wiring.package; (&(osgi.wiring.package=com.google.common.base)(version>=16.0.0)(!(version>=17.0.0)))
```
Wonder where the `(!(version>=17.0.0))` is coming from..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40509069

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-pull-requests #753](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/753/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40335850

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by Ignasi Barrera <no...@github.com>.

IIRC karaf and labs/management also depend on Guava.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40402685

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by Andrew Phillips <no...@github.com>.

> Running mvn clean install against all the dependencies (jclouds, jclouds-labs*, jclouds-chef) 
> resolved them for me.

Ah, OK, then it looks like something with the deps. Wonder what we can do on DEV@cloud to fix this. I'll try locally first.

Thanks, @andrewgaul!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40520753

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by Andrew Gaul <no...@github.com>.

Closed #345.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by Andrew Phillips <no...@github.com>.

> jclouds-java-7-pull-requests #1223 UNSTABLE

Unrelated [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1223/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/).

Code change itself looks good to me. @andrewgaul: do we know how/if this might impact labs, or other downstream repos? I guess we should try to have equivalent PRs open for those?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40392619

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by Andrew Gaul <no...@github.com>.

@demobox I saw similar odd warnings when testing locally.  Running mvn clean install against all the dependencies (jclouds, jclouds-labs*, jclouds-chef) resolved them for me.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40517457

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by Andrew Gaul <no...@github.com>.

`mvn test` passes against core, labs, and karaf.  Pushed commits to all three repositories.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40440623

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds #1024](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1024/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40335156

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by Andrew Phillips <no...@github.com>.

> mvn test passes against core, labs, and karaf. 

Against karaf, `mvn integration-test` probably needs to be run too. Not happy on BuildHive right now, but that might be a stale deps thing. Trying to get the DEV@cloud build happy again at the moment.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40505700

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-java-7-pull-requests #1223](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1223/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/345#issuecomment-40336103