You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2024/01/05 17:10:40 UTC
[PR] Add auto options for all experimental plugins [trafficserver]
JosiahWI opened a new pull request, #10967:
URL: https://github.com/apache/trafficserver/pull/10967
Auto options were added for the experimental plugins with special dependencies in #10741. This adds options for the remaining experimental plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-2073558319
This is about ready, but I still have to solve the problem of ImageMagick being used both in both the webp_transform and magick plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-2068343516
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-2113627046
A CMake issue that caused the necessity for a workaround for ImageMagick is being tracked here: https://gitlab.kitware.com/cmake/cmake/-/issues/25970.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-1881979131
[approve ci osx]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-2077636366
It was discussed that it is clearer to have auto_options just set the `USE_XXX` variables, and put the logic to add the subdirectories in `experimental/CMakeLists.txt`. I will update the PR with this change at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-2074897411
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-1905041912
[approve ci osx]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-1879115643
Blocking on #10968.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI merged PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-2150606736
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-1882015975
The OSX failure is due to a CMake issue present in master. I discussed it with @cmcfarlen and am working on a fix. Marking this as a draft until then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-1879055979
In case it's helpful:
https://ci.trafficserver.apache.org/job/Github_Builds/job/ubuntu/3647/console
```
INFO: YAML_CPP version 0.8.0
CMake Error at cmake/AutoOptionHelpers.cmake:142 (add_subdirectory):
add_subdirectory given source "plugins/experimental/hook_trace" which is
not an existing directory.
Call Stack (most recent call first):
cmake/ExperimentalPlugins.cmake:111 (auto_option)
CMakeLists.txt:604 (include)
```
Thanks for working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "leontian (via GitHub)" <gi...@apache.org>.
leontian commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-2155678550
@cmcfarlen auto options for stale_response plugin was not added when cherry-picked to v10.0.x, also missing add_subdirectory(http_stats). These 2 plugins are not built with latest 10.0.x and BUILD_EXPERIMENTAL_PLUGINS=ON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add auto options for all experimental plugins [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10967:
URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-2155722778
Thank you for reporting, @leontian, those two were indeed missed. I will PR a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org