You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Deepak Barr <de...@gmail.com> on 2016/07/28 19:03:08 UTC
Review Request 50579: LENS-952 : Bump up enunciate version to work
with java 8
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-952
https://issues.apache.org/jira/browse/LENS-952
Repository: lens
Description
-------
Bump up enunciate version to work with java 8
Diffs
-----
lens-server/enunciate.xml 7013f13
lens-server/pom.xml 2294b2a
pom.xml 176fb0e
Diff: https://reviews.apache.org/r/50579/diff/
Testing
-------
Yes.
Ran "mvn clean install -Penunciate" successfully.
Thanks,
Deepak Barr
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Deepak Barr <de...@gmail.com>.
> On July 29, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/enunciate.xml, line 22
> > <https://reviews.apache.org/r/50579/diff/1/?file=1456802#file1456802line22>
> >
> > Why is this falcon?
My bad. I had updated enunciate for falcon as well. Copy-paste mistake. Will fix.
> On July 29, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/enunciate.xml, line 29
> > <https://reviews.apache.org/r/50579/diff/1/?file=1456802#file1456802line29>
> >
> > Dont we require custom handling for FormDataParam anymore ?
> >
> > Can you validate generated doc is fine and confirm?
No, we dont require it anymore in the latest version. Reference - https://github.com/stoicflame/enunciate/issues/85
> On July 29, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/pom.xml, line 417
> > <https://reviews.apache.org/r/50579/diff/1/?file=1456803#file1456803line417>
> >
> > Why are we saying source and target as 1.7? Will it work with 1.8 as well?
Yes, It will work with both 1.7 and 1.8 if I set it to 1.7.
If I set it to 1.8, It will only work with 1.8. Should I change it to 1.8 ??
> On July 29, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote:
> > pom.xml, line 1870
> > <https://reviews.apache.org/r/50579/diff/1/?file=1456804#file1456804line1870>
> >
> > We should change or remove jdk version here.
Yeah, we can remove this. The enunciate works just fine without the activation tag. It seems unnecessary.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review144053
-----------------------------------------------------------
On July 28, 2016, 7:03 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated July 28, 2016, 7:03 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 2294b2a
> pom.xml 176fb0e
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 29, 2016, 4:39 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/pom.xml, line 417
> > <https://reviews.apache.org/r/50579/diff/1/?file=1456803#file1456803line417>
> >
> > Why are we saying source and target as 1.7? Will it work with 1.8 as well?
>
> Deepak Barr wrote:
> Yes, It will work with both 1.7 and 1.8 if I set it to 1.7.
>
> If I set it to 1.8, It will only work with 1.8. Should I change it to 1.8 ??
Nope. If latest enunciate can work with both, we can leave to 1.7, as the compile is still supporting 1.7.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review144053
-----------------------------------------------------------
On July 28, 2016, 7:03 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated July 28, 2016, 7:03 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 2294b2a
> pom.xml 176fb0e
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review144053
-----------------------------------------------------------
lens-server/enunciate.xml (line 22)
<https://reviews.apache.org/r/50579/#comment210032>
Why is this falcon?
lens-server/enunciate.xml
<https://reviews.apache.org/r/50579/#comment210033>
Dont we require custom handling for FormDataParam anymore ?
Can you validate generated doc is fine and confirm?
lens-server/pom.xml (line 417)
<https://reviews.apache.org/r/50579/#comment210034>
Why are we saying source and target as 1.7? Will it work with 1.8 as well?
pom.xml (line 1870)
<https://reviews.apache.org/r/50579/#comment210031>
We should change or remove jdk version here.
- Amareshwari Sriramadasu
On July 28, 2016, 7:03 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated July 28, 2016, 7:03 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 2294b2a
> pom.xml 176fb0e
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review145310
-----------------------------------------------------------
Deepak, Can you incorporate review comments and update the changes?
- Amareshwari Sriramadasu
On July 28, 2016, 7:03 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated July 28, 2016, 7:03 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 2294b2a
> pom.xml 176fb0e
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Deepak Barr <de...@gmail.com>.
> On Aug. 1, 2016, 11:26 a.m., Raju Bairishetti wrote:
> > pom.xml, line 1870
> > <https://reviews.apache.org/r/50579/diff/1/?file=1456804#file1456804line1870>
> >
> > Can we remove enunciate profile completely and move plugin to **build** section?
Addressed in the latest patch.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review144322
-----------------------------------------------------------
On Aug. 16, 2016, 1:39 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2016, 1:39 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 86343fd
> pom.xml f7ebee6
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review144322
-----------------------------------------------------------
pom.xml (line 1870)
<https://reviews.apache.org/r/50579/#comment210344>
Can we remove enunciate profile completely and move plugin to **build** section?
- Raju Bairishetti
On July 28, 2016, 7:03 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated July 28, 2016, 7:03 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 2294b2a
> pom.xml 176fb0e
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review146157
-----------------------------------------------------------
Ship it!
Ship It!
- Raju Bairishetti
On Aug. 16, 2016, 1:39 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2016, 1:39 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 86343fd
> pom.xml f7ebee6
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review146335
-----------------------------------------------------------
lens-server/enunciate.xml (line 29)
<https://reviews.apache.org/r/50579/#comment212709>
Looks like there is an indention issue. Can you revert these extra white spaces(i.e. keep two spaces indentation in modules section)?
- Raju Bairishetti
On Aug. 16, 2016, 1:39 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2016, 1:39 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 86343fd
> pom.xml f7ebee6
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Deepak Barr <de...@gmail.com>.
> On Aug. 17, 2016, 1:37 p.m., Raju Bairishetti wrote:
> > lens-server/pom.xml, line 416
> > <https://reviews.apache.org/r/50579/diff/2/?file=1475521#file1475521line416>
> >
> > I feel like we do not need to specify source and target java versions. Can you verify once?
> >
> >
> > Overall Changes looks fine to me.
Sure. Let me verify and confirm.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review145982
-----------------------------------------------------------
On Aug. 16, 2016, 1:39 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2016, 1:39 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 86343fd
> pom.xml f7ebee6
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Deepak Barr <de...@gmail.com>.
> On Aug. 17, 2016, 1:37 p.m., Raju Bairishetti wrote:
> > lens-server/pom.xml, line 416
> > <https://reviews.apache.org/r/50579/diff/2/?file=1475521#file1475521line416>
> >
> > I feel like we do not need to specify source and target java versions. Can you verify once?
> >
> >
> > Overall Changes looks fine to me.
>
> Deepak Barr wrote:
> Sure. Let me verify and confirm.
Raju, It does not work if I remove source and target. It fails on both java 7 and 8.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review145982
-----------------------------------------------------------
On Aug. 16, 2016, 1:39 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2016, 1:39 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 86343fd
> pom.xml f7ebee6
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/#review145982
-----------------------------------------------------------
lens-server/pom.xml (line 405)
<https://reviews.apache.org/r/50579/#comment212329>
I feel like we do not need to specify source and target java versions. Can you verify once?
Overall Changes looks fine to me.
- Raju Bairishetti
On Aug. 16, 2016, 1:39 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50579/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2016, 1:39 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-952
> https://issues.apache.org/jira/browse/LENS-952
>
>
> Repository: lens
>
>
> Description
> -------
>
> Bump up enunciate version to work with java 8
>
>
> Diffs
> -----
>
> lens-server/enunciate.xml 7013f13
> lens-server/pom.xml 86343fd
> pom.xml f7ebee6
>
> Diff: https://reviews.apache.org/r/50579/diff/
>
>
> Testing
> -------
>
> Yes.
> Ran "mvn clean install -Penunciate" successfully.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/
-----------------------------------------------------------
(Updated Aug. 24, 2016, 7:30 a.m.)
Review request for lens.
Changes
-------
Fixed indentation.
Bugs: LENS-952
https://issues.apache.org/jira/browse/LENS-952
Repository: lens
Description
-------
Bump up enunciate version to work with java 8
Diffs (updated)
-----
lens-server/enunciate.xml 7013f13
lens-server/pom.xml 86343fd
pom.xml f7ebee6
Diff: https://reviews.apache.org/r/50579/diff/
Testing
-------
Yes.
Ran "mvn clean install -Penunciate" successfully.
Thanks,
Deepak Barr
Re: Review Request 50579: LENS-952 : Bump up enunciate version to
work with java 8
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50579/
-----------------------------------------------------------
(Updated Aug. 16, 2016, 1:39 p.m.)
Review request for lens.
Changes
-------
Addressed review comments.
Ran "mvn clean install" and "mvn clean enunciate:docs" successfully.
Bugs: LENS-952
https://issues.apache.org/jira/browse/LENS-952
Repository: lens
Description
-------
Bump up enunciate version to work with java 8
Diffs (updated)
-----
lens-server/enunciate.xml 7013f13
lens-server/pom.xml 86343fd
pom.xml f7ebee6
Diff: https://reviews.apache.org/r/50579/diff/
Testing
-------
Yes.
Ran "mvn clean install -Penunciate" successfully.
Thanks,
Deepak Barr