You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by rekhajoshm <gi...@git.apache.org> on 2015/01/20 23:29:03 UTC

[GitHub] storm pull request: Storm 528

GitHub user rekhajoshm opened a pull request:

    https://github.com/apache/storm/pull/389

    Storm 528

    @harshach - For https://issues.apache.org/jira/browse/STORM-528
    The overriding of codeDir is intended to remove duplicates python, ruby, js external resources in codebase. ATM, I have not intentionally updated all clients to use this signature to override codeDir as that would change API drastically, and need consensus.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rekhajoshm/storm STORM-528

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #389
    
----
commit ca255cc7f622b01e1e8869d1089583b7a4170d94
Author: Joshi <rj...@mtvl122dc9fdc.local>
Date:   2015-01-20T21:23:27Z

    STORM-469

commit 5344f3ac0badaa213412bca98abc395842dc99eb
Author: Joshi <rj...@mtvl122dc9fdc.local>
Date:   2015-01-20T21:33:41Z

    STORM-528

commit 5b6c0ca7e10bdc5e29fbe804e9f0a640f0ced484
Author: Joshi <rj...@mtvl122dc9fdc.local>
Date:   2015-01-20T22:25:37Z

    STORM-528: removed 469 files

commit 6361ef3467e27a63908c264ae83eba574308aa9d
Author: Joshi <rj...@mtvl122dc9fdc.local>
Date:   2015-01-20T22:27:48Z

    STORM 528: remoevd STORM 469 files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 528

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/389#issuecomment-72539951
  
    There is a lot of code in here that I don't understand how it relates to STORM-528.  Setting the code dir, is not really something that I think we want to expose, except a controlled way for testing.  I also don't understand all of the code for max pending.  It looks like you have code from multiple JIRA here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 528

Posted by rekhajoshm <gi...@git.apache.org>.

Github user rekhajoshm commented on the pull request:

    https://github.com/apache/storm/pull/389#issuecomment-74449611
  
    closing to correct branch issue.thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 528

Posted by rekhajoshm <gi...@git.apache.org>.

Github user rekhajoshm closed the pull request at:

    https://github.com/apache/storm/pull/389


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---