You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/24 10:05:09 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #23079: Fix CompletableFuture.anyOf missing callback in tasks runner
sandynz opened a new pull request, #23079:
URL: https://github.com/apache/shardingsphere/pull/23079
Changes proposed in this pull request:
- Fix CompletableFuture.anyOf missing callback in tasks runner
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23079: Fix CompletableFuture.anyOf missing callback in tasks runner
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23079:
URL: https://github.com/apache/shardingsphere/pull/23079#issuecomment-1364507945
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23079?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23079](https://codecov.io/gh/apache/shardingsphere/pull/23079?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d46dcc3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/34a5db9f95120e900a86c01ad7d66bbbb7f98d00?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34a5db9) will **decrease** coverage by `0.02%`.
> The diff coverage is `12.19%`.
```diff
@@ Coverage Diff @@
## master #23079 +/- ##
============================================
- Coverage 49.99% 49.96% -0.03%
Complexity 2426 2426
============================================
Files 4112 4112
Lines 57376 57389 +13
Branches 9049 9058 +9
============================================
- Hits 28683 28676 -7
- Misses 26185 26205 +20
Partials 2508 2508
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ine/core/task/InventoryIncrementalTasksRunner.java](https://codecov.io/gh/apache/shardingsphere/pull/23079/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL3Rhc2svSW52ZW50b3J5SW5jcmVtZW50YWxUYXNrc1J1bm5lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...data/pipeline/mysql/ingest/client/MySQLClient.java](https://codecov.io/gh/apache/shardingsphere/pull/23079/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlhbGVjdC9teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9teXNxbC9pbmdlc3QvY2xpZW50L015U1FMQ2xpZW50LmphdmE=) | `55.55% <0.00%> (-0.84%)` | :arrow_down: |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/23079/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvQ29udGV4dE1hbmFnZXIuamF2YQ==) | `54.92% <100.00%> (+0.69%)` | :arrow_up: |
| [...ngsphere/infra/util/reflection/ReflectionUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/23079/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9yZWZsZWN0aW9uL1JlZmxlY3Rpb25VdGlsLmphdmE=) | `30.95% <0.00%> (-41.27%)` | :arrow_down: |
| [...ion/xa/jta/datasource/XATransactionDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/23079/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL3R5cGUveGEvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24veGEvanRhL2RhdGFzb3VyY2UvWEFUcmFuc2FjdGlvbkRhdGFTb3VyY2UuamF2YQ==) | `97.05% <0.00%> (+5.39%)` | :arrow_up: |
| [...ool/metadata/DataSourcePoolMetaDataReflection.java](https://codecov.io/gh/apache/shardingsphere/pull/23079/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvbWV0YWRhdGEvRGF0YVNvdXJjZVBvb2xNZXRhRGF0YVJlZmxlY3Rpb24uamF2YQ==) | `100.00% <0.00%> (+27.77%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #23079: Fix CompletableFuture.anyOf missing callback in tasks runner
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #23079:
URL: https://github.com/apache/shardingsphere/pull/23079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org