[axis2] Re: svn commit: r547848 - in /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2: engine/AxisServer.java transport/SimpleAxis2Server.java

[Glen Daniels <gl...@thoughtcraft.com>]

(adding axis2 prefix)

>> Does this work for you? please see svn revision 547859.
>>
>> *new AxisServer(true).deployService("className");
>>
> This seems reasonable to me. I have to agree that it would be better
> to explicitly state the conditions in this case.

+1!

Dims, I think you've made a good point here about -1'ing.  Deepal, could 
you please revert your -1 after the discussion (assuming you're OK with 
AxisServer having the boolean constructor param to allow controlling the 
auto-start)?  I'd really like to see dims' cleanup and API addition 
re-committed.  And all of us in the future should be VERY careful about 
-1's to commits.

I was going to suggest using something like a (VETO) suffix to 
distinguish "conversational" -1s from real vetos, but after some 
thought, the presence of a -1 on a reply to a commit message really 
should be enough, and we should be very aware of the veto power of a -1 
IN THAT CONTEXT.

So a) Deepal, I for one would like to see your -1 reverted, and b) 
thanks for the demonstration of what you were really getting at, dims. :)

--Glen

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org

Re: [axis2] Re: svn commit: r547848 - in /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2: engine/AxisServer.java transport/SimpleAxis2Server.java

[Deepal Jayasinghe <de...@opensource.lk>]

Hi dims all.,
>
>
> Dims, I think you've made a good point here about -1'ing.  Deepal,
> could you please revert your -1 after the discussion (assuming you're
> OK with AxisServer having the boolean constructor param to allow
> controlling the auto-start)?  I'd really like to see dims' cleanup and
> API addition re-committed.  And all of us in the future should be VERY
> careful about -1's to commits.
>
> I was going to suggest using something like a (VETO) suffix to
> distinguish "conversational" -1s from real vetos, but after some
> thought, the presence of a -1 on a reply to a commit message really
> should be enough, and we should be very aware of the veto power of a
> -1 IN THAT CONTEXT.
>
> So a) Deepal, I for one would like to see your -1 reverted, and 
I will revert my -1 , and I am ok with having parameter to control
whether we need to start the server or not. But please do not enforce to
call the start method.
> b) thanks for the demonstration of what you were really getting at,
> dims. :)
of course .

Thanks
Deeapl


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org