[GitHub] [incubator-superset] villebro commented on a change in pull request #10548: fix: handle query exceptions gracefully

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #10548:
URL: https://github.com/apache/incubator-superset/pull/10548#discussion_r466938337



##########
File path: superset/connectors/sqla/models.py
##########
@@ -1193,13 +1234,13 @@ def fetch_metadata(self, commit: bool = True) -> None:
         """Fetches the metadata for the table and merges it in"""
         try:
             table_ = self.get_sqla_table_object()
-        except Exception as ex:
-            logger.exception(ex)
-            raise Exception(
+        except Exception:

Review comment:
       Good point. Having been burned by weird exceptions from SQLA I'm slightly hesitant to do this, but at least we'd catch the clean SQLA exceptions with it and probably avoid the majority of exceptions. And we can always change it to `Exception` later if needed. I'll make the change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org