You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/22 05:14:31 UTC
[GitHub] [yunikorn-core] wilfred-s opened a new pull request, #434: [YUNIKORN-1288] check for pseudo version
wilfred-s opened a new pull request, #434:
URL: https://github.com/apache/yunikorn-core/pull/434
### What is this PR for?
Enforce pseudo version for the scheduler interface repo in the master.
### What type of PR is it?
* [X] - Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1288
### How should this be tested?
The check runs as part of the PR workflow for the master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #434: [YUNIKORN-1288] check for pseudo version
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #434:
URL: https://github.com/apache/yunikorn-core/pull/434#issuecomment-1221841594
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#434](https://codecov.io/gh/apache/yunikorn-core/pull/434?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1733887) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/46777b2b4300348bbc11dcb1ce74281a041fcb35?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46777b2) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #434 +/- ##
=======================================
Coverage 72.35% 72.35%
=======================================
Files 65 65
Lines 9559 9559
=======================================
Hits 6916 6916
Misses 2405 2405
Partials 238 238
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit commented on a diff in pull request #434: [YUNIKORN-1288] check for pseudo version
Posted by GitBox <gi...@apache.org>.
craigcondit commented on code in PR #434:
URL: https://github.com/apache/yunikorn-core/pull/434#discussion_r951497336
##########
Makefile:
##########
@@ -110,7 +110,6 @@ check_scripts: install_shellcheck
# from the Makefile. That caused the pull-request license check run from the github action to
# always pass. The syntax for find is slightly different too but that at least works in a similar
# way on both Mac and Linux. Excluding all .git* files from the checks.
-OS := $(shell uname -s | tr '[:upper:]' '[:lower:]')
Review Comment:
Is this intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit commented on a diff in pull request #434: [YUNIKORN-1288] check for pseudo version
Posted by GitBox <gi...@apache.org>.
craigcondit commented on code in PR #434:
URL: https://github.com/apache/yunikorn-core/pull/434#discussion_r951499285
##########
Makefile:
##########
@@ -110,7 +110,6 @@ check_scripts: install_shellcheck
# from the Makefile. That caused the pull-request license check run from the github action to
# always pass. The syntax for find is slightly different too but that at least works in a similar
# way on both Mac and Linux. Excluding all .git* files from the checks.
-OS := $(shell uname -s | tr '[:upper:]' '[:lower:]')
Review Comment:
Never mind, i see there was a duplicate in the original.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #434: [YUNIKORN-1288] check for pseudo version
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #434: [YUNIKORN-1288] check for pseudo version
URL: https://github.com/apache/yunikorn-core/pull/434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org