[jira] [Resolved] (ACCUMULO-2910) Ineffective null check for replicationSources in Mutation#write()

["Josh Elser (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ACCUMULO-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Elser resolved ACCUMULO-2910.
----------------------------------

    Resolution: Fixed

Fixed. Thanks, Ted.

> Ineffective null check for replicationSources in Mutation#write()
> -----------------------------------------------------------------
>
>                 Key: ACCUMULO-2910
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2910
>             Project: Accumulo
>          Issue Type: Bug
>          Components: replication
>            Reporter: Ted Yu
>            Assignee: Josh Elser
>            Priority: Minor
>             Fix For: 1.7.0
>
>
> {code}
>     if (!replicationSources.isEmpty()) {
>       // Use 2nd least-significant bit for whether or not we have replication sources
>       hasValues = (byte) (0x02 | hasValues);
>     }
> ...
>     if (0x02 == (0x02 & hasValues)) {
>       if (null == replicationSources) {
> {code}
> The null check in 'if (0x02' block is ineffective - replicationSources was dereferenced earlier.



--
This message was sent by Atlassian JIRA
(v6.2#6252)