[jira] Commented: (AVRO-321) Run Java RPC interop tests again

["Philip Zeyliger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828508#action_12828508 ] 

Philip Zeyliger commented on AVRO-321:
--------------------------------------

Looks good overall.  The proof will be when we add a language or two to this suite.  Also, should there be an ant target that runs at least what we have here?  Or, rather, a build.sh target?

For my edification/education, what's the difference between '@' and '$' in ant, in the segment below?
{noformat}
        <sysproperty key="test.dir" value="@{test.dir}"/>
        <sysproperty key="share.dir" value="${share.dir}"/>
{noformat}

bq. RpcReceiveTool.java--sleep(1000)

Why did you need to insert a sleep in here?

bq. Usage: uri protocolFile message_name [ -data d | -file f ]"

I think this might be more appropriately "uri protocol_file message_name (--data d|--file f)" to indicate that one of data or file is required.  We should file a bug for the fact that HttpServer doesn't let you specify what IP to bind to.  (Same goes for RpcSendTool.) 

We should in theory check the scheme of the URI too for valid values.

bq. datum = Util.datumFromFile(file.value(opts)); 

Do we need to check that the file's schema and the protocol schema are identical?  Or, rather, read the file using the protocol schema: yes, I think we need to do the latter.

bq. static Object datumFromFile(String file)

I'm a bit of a worrywart: if this sends only one request (it's conceivable for it to replay a set of them), we should perhaps check that in.hasNext() is false.

bq. TestRpcReceiveAndSendTools.java

There's no test for the "-file" path.

bq. share/test/interop/bin/test_rpc_interop.sh: sleep 1

Might be nice to leave a comment why that sleep needs to be there.  I tried a couple of things, but couldn't get around it.

> Run Java RPC interop tests again
> --------------------------------
>
>                 Key: AVRO-321
>                 URL: https://issues.apache.org/jira/browse/AVRO-321
>             Project: Avro
>          Issue Type: Test
>          Components: build, java
>            Reporter: Jeff Hammerbacher
>            Assignee: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-321.patch, AVRO-321.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.