You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "John Plevyak (JIRA)" <ji...@apache.org> on 2010/11/24 19:37:14 UTC

[jira] Created: (TS-560) ram cache compression should not be done under the partition lock

ram cache compression should not be done under the partition lock
-----------------------------------------------------------------

                 Key: TS-560
                 URL: https://issues.apache.org/jira/browse/TS-560
             Project: Traffic Server
          Issue Type: Bug
          Components: Cache
    Affects Versions: 2.1.5
            Reporter: John Plevyak
            Assignee: John Plevyak




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-560) ram cache compression should not be done under the partition lock

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak updated TS-560:
----------------------------

    Attachment: ts-560-jp-2.patch

> ram cache compression should not be done under the partition lock
> -----------------------------------------------------------------
>
>                 Key: TS-560
>                 URL: https://issues.apache.org/jira/browse/TS-560
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 2.1.5
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.5
>
>         Attachments: ts-560-jp-2.patch, ts-650-jp-1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-560) ram cache compression should not be done under the partition lock

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974273#action_12974273 ] 

Leif Hedstrom commented on TS-560:
----------------------------------

Cool! One question: Is it required that you have at least one "task" thread for this to work ? I'm wondering if we should keep the default to 0 task threads, which would schedule these continuations on the net threads instead. I know, it doesn't get you anything, but gives a user the option to decide. If it is required, then maybe we should have the number of task threads also be dependant on enabling cache compression?

> ram cache compression should not be done under the partition lock
> -----------------------------------------------------------------
>
>                 Key: TS-560
>                 URL: https://issues.apache.org/jira/browse/TS-560
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 2.1.5
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.5
>
>         Attachments: ts-650-jp-1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-560) ram cache compression should not be done under the partition lock

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak updated TS-560:
----------------------------

    Attachment: ts-650-jp-1.patch

> ram cache compression should not be done under the partition lock
> -----------------------------------------------------------------
>
>                 Key: TS-560
>                 URL: https://issues.apache.org/jira/browse/TS-560
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 2.1.5
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.5
>
>         Attachments: ts-650-jp-1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-560) ram cache compression should not be done under the partition lock

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974299#action_12974299 ] 

John Plevyak commented on TS-560:
---------------------------------

We could certainly do that.... it isn't like threads are expensive though, if they are not used.
We should add a comment at the compression option that it would be best to add one or
more task threads....

> ram cache compression should not be done under the partition lock
> -----------------------------------------------------------------
>
>                 Key: TS-560
>                 URL: https://issues.apache.org/jira/browse/TS-560
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 2.1.5
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.5
>
>         Attachments: ts-650-jp-1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-560) ram cache compression should not be done under the partition lock

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974421#action_12974421 ] 

Leif Hedstrom commented on TS-560:
----------------------------------

I think that would be my vote. Incorporate the new change in records.config, but set it to 0 for now. We can always change this default later if necessary as well. But yeah, threads are fairly cheap, so either way is ok. (I just want to make sure that cache compression works even if this setting is set to 0, otherwise, we have an undocumented dependencies which could end up ugly).

> ram cache compression should not be done under the partition lock
> -----------------------------------------------------------------
>
>                 Key: TS-560
>                 URL: https://issues.apache.org/jira/browse/TS-560
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 2.1.5
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.5
>
>         Attachments: ts-650-jp-1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-560) ram cache compression should not be done under the partition lock

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-560:
-----------------------------

    Fix Version/s: 2.1.5

> ram cache compression should not be done under the partition lock
> -----------------------------------------------------------------
>
>                 Key: TS-560
>                 URL: https://issues.apache.org/jira/browse/TS-560
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 2.1.5
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.5
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-560) ram cache compression should not be done under the partition lock

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977397#action_12977397 ] 

John Plevyak commented on TS-560:
---------------------------------

New patch attached.  This one produces errors and warnings for mis-set configurations.

> ram cache compression should not be done under the partition lock
> -----------------------------------------------------------------
>
>                 Key: TS-560
>                 URL: https://issues.apache.org/jira/browse/TS-560
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 2.1.5
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.5
>
>         Attachments: ts-560-jp-2.patch, ts-650-jp-1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.