You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "scholarsmate (via GitHub)" <gi...@apache.org> on 2023/03/22 13:22:19 UTC
[GitHub] [daffodil-vscode] scholarsmate opened a new pull request, #511: move error msg and add instrux in edit vpt in single byte mode
scholarsmate opened a new pull request, #511:
URL: https://github.com/apache/daffodil-vscode/pull/511
Relocates the error message in single byte mode closer to where the error is taking place. Also adds an instruction message in the edit viewport in single byte mode. Here is the screenshot with this patch applied:
<img width="1048" alt="Screenshot 2023-03-22 at 9 15 24 AM" src="https://user-images.githubusercontent.com/2205472/226917008-3afe6f5c-2ced-43a6-962b-7767481d9182.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #511: move error msg and add instrux in edit vpt in single byte mode
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #511:
URL: https://github.com/apache/daffodil-vscode/pull/511#issuecomment-1479793488
@arosien, will you please review this? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate merged pull request #511: move error msg and add instrux in edit vpt in single byte mode
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate merged PR #511:
URL: https://github.com/apache/daffodil-vscode/pull/511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #511: move error msg and add instrux in edit vpt in single byte mode
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #511:
URL: https://github.com/apache/daffodil-vscode/pull/511#issuecomment-1479577573
Improved the cosmetics of the error message div a bit in the last forced push. Here is what it looks like now:
<img width="256" alt="Screenshot 2023-03-22 at 9 33 08 AM" src="https://user-images.githubusercontent.com/2205472/226920634-4d60176a-c0d4-437a-91bb-639b462760aa.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org