You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/10/25 03:16:28 UTC

[GitHub] [zeppelin] jenil-shah135 commented on a change in pull request #3953: [ZEPPELIN-5105] Add an option to allow S3 path based access

jenil-shah135 commented on a change in pull request #3953:
URL: https://github.com/apache/zeppelin/pull/3953#discussion_r511540643



##########
File path: zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-common.interface.ts
##########
@@ -118,6 +118,7 @@ export interface ConfigurationsInfo {
     'zeppelin.notebook.collaborative.mode.enable': string;
     'zeppelin.search.use.disk': string;
     'zeppelin.notebook.s3.cannedAcl': string;
+    'zeppelin.notebook.s3.pathStyleAccess': string;

Review comment:
       I don't think so any changes for old ui is required as it is using rest service to get all configuration keys which is using ZeppelinConfiguration. In that file I have already made required changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org