You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2007/12/11 01:12:43 UTC
[jira] Created: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Lease holder information should be passed in ClientProtocol.abandonBlock(...)
-----------------------------------------------------------------------------
Key: HADOOP-2401
URL: https://issues.apache.org/jira/browse/HADOOP-2401
Project: Hadoop
Issue Type: Improvement
Components: dfs
Affects Versions: 0.15.0
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
Fix For: 0.16.0
Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Attachment: (was: 2401_20071210b.patch)
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550295 ]
dhruba borthakur commented on HADOOP-2401:
------------------------------------------
I like the unit test. However, I would still like MiniDFSCluster to continue to use Namenode.createNameNode() (to make it behave like a true server). The unit test could create a new DFSClient connection using new DFSClient(addr, conf) and then invoke abandon block on that client.
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Attachment: 2401_20071210.patch
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Attachment: 2401_20071211.patch
> However, I would still like MiniDFSCluster to continue to use Namenode.createNameNode() (to make it behave like a true server). The unit test could create a new DFSClient connection using new DFSClient(addr, conf) and then invoke abandon block on that client.
Sure, reverted the change in MiniDFSCluster and DFSClient is used in TestAbandonBlock now.
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch, 2401_20071211.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-2401:
-------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks Nicholas!
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch, 2401_20071211.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Status: Patch Available (was: Open)
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch, 2401_20071211.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550306 ]
Hadoop QA commented on HADOOP-2401:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12371400/2401_20071210c.patch
against trunk revision r603084.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1313/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1313/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1313/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1313/console
This message is automatically generated.
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Status: Patch Available (was: Open)
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Status: Open (was: Patch Available)
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch, 2401_20071211.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550722 ]
Hadoop QA commented on HADOOP-2401:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12371452/2401_20071211.patch
against trunk revision r603315.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests -1. The patch failed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1320/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1320/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1320/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1320/console
This message is automatically generated.
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch, 2401_20071211.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550257 ]
dhruba borthakur commented on HADOOP-2401:
------------------------------------------
+1 code looks good. I guess it will be difficult to write a unit test for this one, is that right?
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Status: Open (was: Patch Available)
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Attachment: (was: 2401_20071210.patch)
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210b.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Attachment: 2401_20071210b.patch
- added a test. The test also illustrates how a malicious client can do abondanBlock(...) if the lease holder is not checked.
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210b.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550714 ]
dhruba borthakur commented on HADOOP-2401:
------------------------------------------
+1.
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch, 2401_20071211.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Status: Patch Available (was: Open)
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210b.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2401:
-------------------------------------------
Attachment: 2401_20071210c.patch
forgot to do "svn add" in my previous file
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2401) Lease holder information should be
passed in ClientProtocol.abandonBlock(...)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550944 ]
Hudson commented on HADOOP-2401:
--------------------------------
Integrated in Hadoop-Nightly #330 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/330/])
> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
> Key: HADOOP-2401
> URL: https://issues.apache.org/jira/browse/HADOOP-2401
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.16.0
>
> Attachments: 2401_20071210c.patch, 2401_20071211.patch
>
>
> Logically, only the lease holder can do abandonBlock(...). However, since the file is visible to the other clients once it has been created. It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet). Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.