[kudu-CR] row serialization: dedupe string columns

["Andrew Wong (Code Review)" <ge...@cloudera.org>]

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15806 )

Change subject: row_serialization: dedupe string columns
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Not sure what's up with the build failures though.

http://gerrit.cloudera.org:8080/#/c/15806/1/src/kudu/common/row_serialization.cc
File src/kudu/common/row_serialization.cc:

http://gerrit.cloudera.org:8080/#/c/15806/1/src/kudu/common/row_serialization.cc@199
PS1, Line 199:   pair<bool, size_t> AddOrGetExisting(const uint8_t* p, size_t off) {
nit: add docs. Mentioning the units of the keys and values would be nice too.


http://gerrit.cloudera.org:8080/#/c/15806/1/src/kudu/common/row_serialization.cc@272
PS1, Line 272: ins_pair
nit: `missed_and_offset` or somesuch would be more self-documenting



-- 
To view, visit http://gerrit.cloudera.org:8080/15806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I056cd57b9eea1d6988b8ab053d86a3493361dc6b
Gerrit-Change-Number: 15806
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 May 2020 06:28:35 +0000
Gerrit-HasComments: Yes