[jira] [Commented] (PHOENIX-1824) Run all IT's through Query Server

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746110#comment-14746110 ] 

Josh Elser commented on PHOENIX-1824:
-------------------------------------

With CALCITE-840 nearing application (start using protobuf as the serialization mechanism instead of JSON), I'd like to really put PQS through its paces. As such, I'd like to try to pick up Nick's WIP patch and see where we can take it.

As an outsider looking in through the window at this point, recommendations on how to proceed are appreciated. Looking back at [~jesse_yates]'s recommendations, moving ITs into a phoenix-it module makes sense and pave the way towards some of [~jamestaylor]'s thoughts.

Trying to support a full breadth of testing is tough (salting, indexing, etc), and can really explode the build. One immediate question I have is about which of the following is preferred: tests are run in one expected/normal way with the ability to flip toggles for different attributes (e.g. salted=true), or run the full product of all configurations each time? I think making a decision on that will really determine whether Parameterized is a reasonable approach or not. My gut reaction is that the former is preferable. For my selfish interests of testing out Avatica changes in Calcite, it's relatively simple to introduce a toggle to switch the Driver in use by the tests.

[~samarthjain] or [~gabriel.reid] did you have anything to add?

> Run all IT's through Query Server
> ---------------------------------
>
>                 Key: PHOENIX-1824
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1824
>             Project: Phoenix
>          Issue Type: Test
>    Affects Versions: 4.4.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 1824.wip.patch
>
>
> Once we have PHOENIX-971 merged, we can increase our confidence in the server by parameterizing our IT suite to run over either driver, or both. This will probably require refactoring the IT suite out of phoenix-core/src/it into a separate module so that module can depend on both phoenix-core and phoenix-server modules.
> This is looking like it will also depend on improvements to Calcite that may not make it into 1.2 release (as RC's for that release have already started).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)