[jira] [Commented] (NIFI-2323) Improve handling of Oracle datetime columns in QueryDatabaseTable and GenerateTableFetch

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964583#comment-15964583 ] 

ASF GitHub Bot commented on NIFI-2323:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/1664

    NIFI-2323: Fixed Oracle timestamp handling in DB fetch processors

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-2323

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1664.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1664
    
----
commit 5d163b7061e4d12269db7c514fa15052df4553ad
Author: Matt Burgess <ma...@apache.org>
Date:   2017-04-11T16:00:31Z

    NIFI-2323: Fixed Oracle timestamp handling in DB fetch processors

----


> Improve handling of Oracle datetime columns in QueryDatabaseTable and GenerateTableFetch
> ----------------------------------------------------------------------------------------
>
>                 Key: NIFI-2323
>                 URL: https://issues.apache.org/jira/browse/NIFI-2323
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 0.6.0
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>
> Due to default handling of Oracle columns returned as java.sql.Date types, the string literals used to compare against the column values must be in the same format as the NLS_DATE_FORMAT setting of the database (often YYYY-MM-DD).
> I believe when "Oracle" is provided as the database type (formerly known as pre-processing strategy), Oracle's Datetime Functions (such as TO_DATE or TO_TIMESTAMP) could be leveraged to give more fine-grained maximum-value information.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)