You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Chamikara Madhusanka Jayalath (Jira)" <ji...@apache.org> on 2021/10/12 23:36:00 UTC

[jira] [Commented] (BEAM-7996) Add support for remaining data types in python RowCoder

    [ https://issues.apache.org/jira/browse/BEAM-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427957#comment-17427957 ] 

Chamikara Madhusanka Jayalath commented on BEAM-7996:
-----------------------------------------------------

This is something we potentially want to prioritize to better support RowCoder for x-lang.

> Add support for remaining data types in python RowCoder 
> --------------------------------------------------------
>
>                 Key: BEAM-7996
>                 URL: https://issues.apache.org/jira/browse/BEAM-7996
>             Project: Beam
>          Issue Type: New Feature
>          Components: cross-language, sdk-py-core
>            Reporter: Brian Hulette
>            Priority: P1
>          Time Spent: 9h 20m
>  Remaining Estimate: 0h
>
> In the initial [python RowCoder implementation|https://github.com/apache/beam/pull/9188] we only added support for the data types that already had coders in the Python SDK. We should add support for the remaining data types that are not currently supported:
> * INT8 (ByteCoder in Java)
> * INT16 (BigEndianShortCoder in Java)
> * FLOAT (FloatCoder in Java) (Note: doubles are supported, this is specifically for single-precision)
> * --BOOLEAN (standard beam:coder:bool:v1, BooleanCoder in Java)--
> * --BYTES (standard beam:coder:bytes:v1, ByteArrayCoder in Java)--
> * --Map (MapCoder in Java)--
> We might consider making those coders standard so they can be tested independently from RowCoder in standard_coders.yaml. Or, if we don't do that we should probably add a more robust testing framework for RowCoder itself, because it will be challenging to test all of these types as part of the RowCoder tests in standard_coders.yaml.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)