You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/18 16:47:24 UTC

[GitHub] [kafka] edoardocomar commented on pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

edoardocomar commented on pull request #4204:
URL: https://github.com/apache/kafka/pull/4204#issuecomment-646162106


   After @hachikuji fixes in https://github.com/apache/kafka/pull/8586 
   the metrics are no longer ticked at the end of a DelayedFetch, so the time window for topic deletion is almost non existent and the only guard code needed is left in `KafkaApis`, as shown by the unit test added by this PR.
   This PR is now tiny and would be nice to have it merged :-)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org