You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/10 00:43:04 UTC

[GitHub] [incubator-superset] codecov-io commented on pull request #11632: fix: js unit test when save dash

codecov-io commented on pull request #11632:
URL: https://github.com/apache/incubator-superset/pull/11632#issuecomment-724373684


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11632?src=pr&el=h1) Report
   > Merging [#11632](https://codecov.io/gh/apache/incubator-superset/pull/11632?src=pr&el=desc) (5c7c623) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5be1dbe28b612f3b38f92ff2b115fd0733e4ac0c?el=desc) (5be1dbe) will **increase** coverage by `0.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11632/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11632?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11632      +/-   ##
   ==========================================
   + Coverage   61.92%   62.83%   +0.91%     
   ==========================================
     Files         422      451      +29     
     Lines       26295    15985   -10310     
     Branches        0     3964    +3964     
   ==========================================
   - Hits        16282    10044    -6238     
   + Misses      10013     5761    -4252     
   - Partials        0      180     +180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.83% <ø> (?)` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11632?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset/migrations/versions/1d2ddd543133\_log\_dt.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZDJkZGQ1NDMxMzNfbG9nX2R0LnB5) | | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | | |
   | [superset/migrations/versions/c18bd4186f15\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jMThiZDQxODZmMTVfLnB5) | | |
   | [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | | |
   | [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | | |
   | [...318dfe5fb6c\_adding\_verbose\_name\_to\_druid\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iMzE4ZGZlNWZiNmNfYWRkaW5nX3ZlcmJvc2VfbmFtZV90b19kcnVpZF9jb2x1bW4ucHk=) | | |
   | [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | | |
   | [superset/migrations/versions/ec1f88a35cc6\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lYzFmODhhMzVjYzZfLnB5) | | |
   | ... and [863 more](https://codecov.io/gh/apache/incubator-superset/pull/11632/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11632?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11632?src=pr&el=footer). Last update [5be1dbe...5c7c623](https://codecov.io/gh/apache/incubator-superset/pull/11632?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org