You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/02/05 07:23:35 UTC
[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #1036: Ftr: registry ip:port set from enviroment variable
gaoxinge commented on a change in pull request #1036:
URL: https://github.com/apache/dubbo-go/pull/1036#discussion_r570766357
##########
File path: registry/base_registry.go
##########
@@ -136,6 +136,13 @@ func (r *BaseRegistry) Register(conf *common.URL) error {
ok bool
err error
)
+ // if developer define registry port and ip, use it first.
+ if ipToRegistry := os.Getenv("DUBBO_IP_TO_REGISTRY"); ipToRegistry != "" {
Review comment:
Why are ip and port from environment instead of configuration?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org