Re: AW: AW: Merge brach with connect API refactoring

[Tim <bo...@posteo.de>]

thanks a lot Philipp!

+1 from my side

Am 31.05.2023 21:30 schrieb Philipp Zehnder:
> Hi Tim,
> 
> I have already created issues for them and most of them should be fixed 
> already.
> I have responded to your comments and I think once we resolve these
> discussions we will be ready to merge the branch.
> 
> Cheers,
> Philipp
> Von: Tim <bo...@posteo.de>
> Datum: Sonntag, 28. Mai 2023 um 16:17
> An: dev@streampipes.apache.org <de...@streampipes.apache.org>
> Betreff: Re: AW: Merge brach with connect API refactoring
> Hi Philipp,
> 
> first of all: huge kudos for all the effort you spent for this PR.
> 
> I left some comments on the PR, apart from that I support your
> suggestion to merge the PR.
> 
> Of the adapters that have not been migrated, the only ones left at this
> time are the following:
> - GdeltAdapter
> - IexCloudNewsAdapter
> - IexCloudStockAdapter
> 
> In my opinion, we can remove them.
> 
> Since you mentioned that there are some minor issues and features that
> are not ready yet:
> Could you list them so that we can create issues for them and keep 
> track
> of the completion status of this great improvement?
> 
> Best
> Tim
> 
> Am 25.05.2023 09:00 schrieb Dominik Riemer:
>> Hi Philipp,
>> 
>> great work!
>> I pushed another commit which fixes a bug when starting multiple
>> adapters of the same type and refactored the code structure a bit to
>> have all interfaces in the extensions-api module.
>> 
>> From my point of view, we can merge this into dev and fix the
>> remaining issues over PRs.
>> 
>> Cheers
>> Dominik
>> 
>> On 2023/05/24 12:59:30 "Obermeier. Stefan" wrote:
>>> Hi Philipp,
>>> 
>>> thank you for this a great improvements!
>>> I like the idea of removing not much used adapters.
>>> 
>>> Cheers,
>>> Stefan
>>> 
>>> 
>>> PS.
>>> I have a possibly small issue with the UI.
>>> In my case the adapters are not shown in /#/connect/create.
>>> 
>>> -----Ursprüngliche Nachricht-----
>>> Von: Philipp Zehnder <ph...@bytefabrik.ai>
>>> Gesendet: Montag, 22. Mai 2023 21:15
>>> An: dev@streampipes.apache.org
>>> Betreff: Merge brach with connect API refactoring
>>> 
>>> Hi all,
>>> 
>>> after the PR [1] has become significantly larger than originally
>>> planned, most features should now be implemented. There are still a
>>> few minor issues, but the main functions should all work.
>>> Since we have already started the branch for the release, I would 
>>> like
>>> to merge the branch into the `dev` branch to be able to test
>>> everything.
>>> 
>>> The adapters in `streampipes-connect-adapters-iiot` [2] are all
>>> updated. Regarding the adapters in `streampipes-connect-adapters`[3] 
>>> I
>>> would suggest removing most of them as they are rather less used. Do
>>> you see it the same way? (For all adapters we want to keep we should
>>> create an issue for the upgrade).
>>> 
>>> If you want to get familiar with the new API you can have a look at
>>> [4] & [5]. If you have any feedback, you can share it here.
>>> 
>>> What is your opinion on the topic, should we merge the branch into
>>> dev? Then we can also start with some issues for adapters that we 
>>> have
>>> pushed to the back.
>>> 
>>> Cheers,
>>> Philipp
>>> 
>>> [1] https://github.com/apache/streampipes/pull/1290
>>> [2]
>>> https://github.com/apache/streampipes/tree/remove-set-adapters/streampipes-extensions/streampipes-connect-adapters-iiot
>>> [3]
>>> https://github.com/apache/streampipes/tree/remove-set-adapters/streampipes-extensions/streampipes-connect-adapters
>>> [4]
>>> https://github.com/apache/streampipes/blob/remove-set-adapters/streampipes-extensions/streampipes-connect-adapters-iiot/src/main/java/org/apache/streampipes/connect/iiot/adapters/simulator/machine/MachineDataSimulatorAdapter.java
>>> [5]
>>> https://github.com/apache/streampipes/blob/remove-set-adapters/streampipes-extensions/streampipes-connect-adapters-iiot/src/main/java/org/apache/streampipes/connect/iiot/protocol/stream/FileReplayAdapter.java
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> SEEBURGER AG            Vorstand/SEEBURGER Executive Board:
>>> Sitz der Gesellschaft/Registered Office:                Axel Haas,
>>> Michael Kleeberg, Axel Otto, Dr. Martin Kuntz, Matthias Feßenbecker
>>> Edisonstr. 1
>>> D-75015 Bretten         Vorsitzende des Aufsichtsrats/Chairperson of
>>> the SEEBURGER Supervisory Board:
>>> Tel.: 07252 / 96 - 0            Prof. Dr. Simone Zeuchner-Egli
>>> Fax: 07252 / 96 - 2222
>>> Internet: http://www.seeburger.de
>>> Registergericht/Commercial Register:
>>> e-mail: info@seeburger.de               HRB 240708 Mannheim
>>> 
>>> 
>>> Dieses E-Mail ist nur für den Empfänger bestimmt, an den es gerichtet
>>> ist und kann vertrauliches bzw. unter das Berufsgeheimnis fallendes
>>> Material enthalten. Jegliche darin enthaltene Ansicht oder
>>> Meinungsäußerung ist die des Autors und stellt nicht notwendigerweise
>>> die Ansicht oder Meinung der SEEBURGER AG dar. Sind Sie nicht der
>>> Empfänger, so haben Sie diese E-Mail irrtümlich erhalten und jegliche
>>> Verwendung, Veröffentlichung, Weiterleitung, Abschrift oder jeglicher
>>> Druck dieser E-Mail ist strengstens untersagt. Weder die SEEBURGER AG
>>> noch der Absender (Obermeier. Stefan) übernehmen die Haftung für
>>> Viren; es obliegt Ihrer Verantwortung, die E-Mail und deren Anhänge
>>> auf Viren zu prüfen.
>>> 
>>> 
>>> This email is intended only for the recipient(s) to whom it is
>>> addressed. This email may contain confidential material that may be
>>> protected by professional secrecy. Any fact or opinion contained, or
>>> expression of the material herein, does not necessarily reflect that
>>> of SEEBURGER AG. If you are not the addressee or if you have received
>>> this email in error, any use, publication or distribution including
>>> forwarding, copying or printing is strictly prohibited. Neither
>>> SEEBURGER AG, nor the sender (Obermeier. Stefan) accept liability for
>>> viruses; it is your responsibility to check this email and its
>>> attachments for viruses.
>>> 
>>>