You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "Kaap10 (via GitHub)" <gi...@apache.org> on 2026/10/19 03:17:26 UTC

[PR] feat(setup): first-run welcome guide for the contributor-growth family (#1658) [magpie]

Kaap10 opened a new pull request, #1702:
URL: https://github.com/apache/magpie/pull/1702

   <!-- SPDX-License-Identifier: Apache-2.0
        https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ## Summary
   
   - Adds a first-run welcome guide for the `contributor-growth` skill family (`plugins/magpie-setup/skills/setup/setup_preflight/guides/contributor-growth.md`), following the template established in #1653 and #1663.
   - Introduces the typical contributor-growth flow (`activity-sweep` → `identity-map` → `contributor-to-committer` → `nomination` → `candidate-screen` → `committer-onboarding`; `sentiment`), highlighting private governance (`<private-list>` confidentiality), calibrated thresholds, and the core principle: *information only, never a readiness verdict*.
   - Provides plain-language invocation prompts across all 9 skills in the family, including `calibrate` and `onboarding-concierge`.
   - Adds preflight-floor eval `case-11-contributor-growth-first-run`, re-renders `case-9-first-magpie-run` to include `contributor-growth` in the general guide, links the guide in `docs/contributor-growth/README.md`, and expands test coverage in `test_welcome.py`.
   
   ## Type of change
   
   - [ ] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
   - [ ] Tool / bridge contract (`tools/<system>/*.md`)
   - [ ] Python package (`tools/*/` with `pyproject.toml`)
   - [ ] Groovy reference impl
   - [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
   - [x] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
   - [ ] Project template (`projects/_template/`)
   - [x] CI / dev loop (`prek`, workflows, validators)
   - [x] Other: Framework setup preflight welcome guide
   
   ## Test plan
   
   - [x] `prek run` static checks pass (markdownlint, mixed-line-ending, doctoc, add-license-headers)
   - [x] For Python packages touched: `pytest` and `ruff check` pass cleanly
   - [ ] For Groovy bridges touched: command-line invocation tested end-to-end
   - [ ] For skill changes: eval suite passes for the affected skill
         (`PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/`)
   - [x] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
         (a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
   - [x] Other: `python tools/dev/render-preflight-fixtures.py --check` passes with zero drift; `pytest tools/setup-preflight/tests/test_welcome.py` passes (50 tests).
   
   ## RFC-AI-0004 compliance
   
   - [ ] **HITL** — any new mutation is gated on explicit user confirmation
   - [ ] **Sandbox** — no new unrestricted host access; network reach declared in the adapter
   - [x] **Vendor neutrality** — placeholders (`<PROJECT>`, `<tracker>`, `<upstream>`, `<security-list>`, `<private-list>`) used in all skill / tool prose (the `check-placeholders` prek hook is the mechanical gate)
   - [x] **Conversational + correctable** — agentic-override path documented if behaviour is adopter-tunable
   - [ ] **Write-access discipline** — no autonomous outbound messages; drafts only, sent on confirmation
   - [ ] **Privacy LLM** — private content does not reach a non-approved LLM; redactor invoked where needed
   
   ## Linked issues
   
   Closes #1658 (child of #1654)
   
   ## Notes for reviewers (optional)
   
   - The guide is 54 lines of Markdown, well under the 70-line limit enforced by `test_each_guide_is_short_and_ends_with_the_way_back`.
   - `case-11` uses the exact `surface_hash` (`sha256:bdf92c88a304ddea`) declared by `contributor-to-committer`.
   - Both `case-11` and `case-9` report fixtures were dynamically generated via `render-preflight-fixtures.py` ensuring zero drift.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(setup): first-run welcome guide for the contributor-growth family (#1658) [magpie]

Posted by "Kaap10 (via GitHub)" <gi...@apache.org>.
Kaap10 commented on PR #1702:
URL: https://github.com/apache/magpie/pull/1702#issuecomment-6259117295

   will resolve CI failure shortly!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(setup): first-run welcome guide for the contributor-growth family (#1658) [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1702:
URL: https://github.com/apache/magpie/pull/1702


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org