You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "YA-MSH (via GitHub)" <gi...@apache.org> on 2023/06/27 09:01:51 UTC

[GitHub] [superset] YA-MSH opened a new issue, #24525: Error when saving a dashboard after editing

YA-MSH opened a new issue, #24525:
URL: https://github.com/apache/superset/issues/24525

   When I open a dashboard in "EDIT" mode and make a change, "SAVE" function doesn't work.
   
   #### How to reproduce the bug
   
   1. From Home, create a new dashboard
   2. At this time "SAVE" button is unavailable (-> grey)
   3. Do any change (rename title, add a chart or layout element)
   4. "SAVE" button becomes available (-> blue)
   5. Clic on "SAVE" button
   
   ### Expected results
   
   The modified dashboard is saved and a success message is displayed.
   
   ### Actual results
   
   Dashboard is not saved and an error message is displayed :
   "Sorry, there was an error saving this dashboard: [object Object]"
   
   In Flask logs:
   ```
   --Logs after "SAVE" in "EDIT DASHBOARD" mode => warning + response code 400
   2023-06-26 15:35:26,358:DEBUG:superset.stats_logger:[36m[stats_logger] (incr) DashboardRestApi.put.warning[0m
   2023-06-26 15:35:26,358:DEBUG:superset.stats_logger:[36m[stats_logger] (timing) DashboardRestApi.put.time | 6.051858072169125 [0m
   2023-06-26 15:35:26,358:INFO:werkzeug:127.0.0.1 - - [26/Jun/2023 15:35:26] "[31m[1mPUT /api/v1/dashboard/1 HTTP/1.1[0m" 400 -
   
   --Logs after renaming title" from "Dashboard properties" panel => success + response code 200
   2023-06-26 15:48:22,248:DEBUG:superset.stats_logger:[36m[stats_logger] (incr) DashboardRestApi.put.success[0m
   2023-06-26 15:48:22,248:DEBUG:superset.stats_logger:[36m[stats_logger] (timing) DashboardRestApi.put.time | 16.117947991006076 [0m
   2023-06-26 15:48:22,249:INFO:werkzeug:127.0.0.1 - - [26/Jun/2023 15:48:22] "PUT /api/v1/dashboard/1 HTTP/1.1" 200 -
   ```
   
   #### Screenshots
   
   ![Superset_save_dashboard_error](https://github.com/apache/superset/assets/137871159/c1eab4a2-1ad9-45da-bf40-2cc6dd77cbc0)
   
   ### Environment
   
   - browser type and version: Firefox 102.12.0esr or Edge 114.0.1823.58
   - superset version: Superset 2.1.0
   - python version: Python 3.10.6
   - node.js version: v12.22.9
   - any feature flags active: none
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [X] I have reproduced the issue with at least the latest released version of superset.
   - [X] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Issue occurs only with "EDIT DASHBOARD" mode, after opening an existing dashboard or directly next creation of new dashboard from home.
   Some other actions on dashboards work fine:
   - Rename dashboard in "Dashboard properties" panel from home or dashboard list (without "EDIT DASHBOARD" mode)
   - Add a chart to a dashboard (existing or new) in "Save chart" panel
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ya-msh commented on issue #24525: Error when saving a dashboard after editing

Posted by "ya-msh (via GitHub)" <gi...@apache.org>.

ya-msh commented on issue #24525:
URL: https://github.com/apache/superset/issues/24525#issuecomment-1740848253

   For my part I didn't do anything else since my last message.
   The workaround I applied still works fine and I didn't notice any side effects.
   Next step is to upgrade to 3.0.0 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] timon-sue commented on issue #24525: Error when saving a dashboard after editing

Posted by "timon-sue (via GitHub)" <gi...@apache.org>.

timon-sue commented on issue #24525:
URL: https://github.com/apache/superset/issues/24525#issuecomment-1680387063

   Any further updates on this? I'm also affected by this bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Error when saving a dashboard after editing [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on issue #24525:
URL: https://github.com/apache/superset/issues/24525#issuecomment-1942153318

   I closed the linked issue (with a lot less conversation than this one) since it's 2.0 specific. Since we no longer support Superset 2.x, I'm tempted to close this one too, but the context here is reasonably recent. Is anyone experiencing this issue in Superset 3.x? Or is anyone willing to open a PR that fixes this for 2.x in case there's some random chance for an opportunistic 2.1.x release (though unlikely)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] sfirke commented on issue #24525: Error when saving a dashboard after editing

Posted by "sfirke (via GitHub)" <gi...@apache.org>.

sfirke commented on issue #24525:
URL: https://github.com/apache/superset/issues/24525#issuecomment-1615129911

   Could be related to https://github.com/apache/superset/issues/22106 (unsolved)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] roks531 commented on issue #24525: Error when saving a dashboard after editing

Posted by "roks531 (via GitHub)" <gi...@apache.org>.

roks531 commented on issue #24525:
URL: https://github.com/apache/superset/issues/24525#issuecomment-1623399811

   as for me i recreated the dashboard with same charts, same filters, css and deleted the old one, which couldnt be updated in any way (filter updates or edit dashboard name, owner, nothing worked). Visually, functionally the dashboard now works the same as before...I dont know what the root cause of this is, but it happened on an update of apache superset to 2.1.0-dev.
   
   I also looked at the browser console and as it seems there was a PUT problem, but i didnt bother investigating further, as it was faster to recreate the dashboard for me.
   
   Chrome browser logs:
   
   `index.js:65     PUT http://domain.com:8088/api/v1/dashboard/12 400 (BAD REQUEST)
   n @ index.js:65
   (anonymous) @ index.js:125
   (anonymous) @ index.js:63
   (anonymous) @ callApi.ts:180
   u @ callApiAndParseWithTimeout.ts:32
   request @ SupersetClientClass.ts:202
   await in request (async)
   put @ SupersetClientClass.ts:180
   put @ SupersetClient.ts:50
   s @ dashboardState.js:399
   Promise.then (async)
   (anonymous) @ dashboardState.js:440
   (anonymous) @ index.js:8
   (anonymous) @ redux.js:477
   overwriteDashboard @ index.jsx:418
   X @ button.js:200
   l @ react-dom.production.min.js:14
   p @ react-dom.production.min.js:14
   (anonymous) @ react-dom.production.min.js:14
   b @ react-dom.production.min.js:15
   ot @ react-dom.production.min.js:52
   rt @ react-dom.production.min.js:51
   it @ react-dom.production.min.js:52
   ft @ react-dom.production.min.js:56
   R @ react-dom.production.min.js:287
   F @ react-dom.production.min.js:19
   Jt @ react-dom.production.min.js:70
   Gt @ react-dom.production.min.js:69
   t.unstable_runWithPriority @ scheduler.production.min.js:19
   Za @ react-dom.production.min.js:122
   z @ react-dom.production.min.js:287
   $t @ react-dom.production.min.js:68`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] YA-MSH commented on issue #24525: Error when saving a dashboard after editing

Posted by "YA-MSH (via GitHub)" <gi...@apache.org>.

YA-MSH commented on issue #24525:
URL: https://github.com/apache/superset/issues/24525#issuecomment-1624919546

   Situation is worst for me: I have a fresh install of Superset in 2.1.0 and no dashboard can be saved from "EDIT DASHBOARD" mode, even an empty dashboard without charts.
   I removed and recreated the metadata database without examples, no change.
   
   Good idea to look at browser log.
   I have some warnings like:
   `Warning: Expected `onClick` listener to be a function, instead got a value of `number` type.`
   
   And for the PUT request
   Request:
   `{"certified_by":"","certification_details":"","css":"","dashboard_title":"test","slug":null,"owners":[1],"json_metadata":"{\"color_scheme\":\"\",\"positions\":{\"DASHBOARD_VERSION_KEY\":\"v2\",\"ROOT_ID\":{\"type\":\"ROOT\",\"id\":\"ROOT_ID\",\"children\":[\"GRID_ID\"]},\"GRID_ID\":{\"type\":\"GRID\",\"id\":\"GRID_ID\",\"children\":[],\"parents\":[\"ROOT_ID\"]},\"HEADER_ID\":{\"id\":\"HEADER_ID\",\"type\":\"HEADER\",\"meta\":{\"text\":\"test\"}}},\"refresh_frequency\":0,\"shared_label_colors\":{},\"color_scheme_domain\":[],\"expanded_slices\":{},\"label_colors\":{},\"timed_refresh_immune_slices\":[],\"cross_filters_enabled\":false,\"default_filters\":\"{}\",\"filter_scopes\":{},\"chart_configuration\":{},\"global_chart_configuration\":{}}"}`
   
   State: 400 BAD REQUEST
   Response:
   `{"message":{"json_metadata":[{"global_chart_configuration":["Unknown field."]}]}}`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org