You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/03/15 00:05:42 UTC

[GitHub] [zookeeper] anmolnar commented on a change in pull request #838: ZOOKEEPER-2168 Add C APIs for new createContainer Methods

anmolnar commented on a change in pull request #838: ZOOKEEPER-2168 Add C APIs for new createContainer Methods
URL: https://github.com/apache/zookeeper/pull/838#discussion_r265811014
 
 

 ##########
 File path: zookeeper-client/zookeeper-client-c/include/proto.h
 ##########
 @@ -40,6 +40,8 @@ extern "C" {
 #define ZOO_RECONFIG_OP 16
 #define ZOO_CHECK_WATCHES 17
 #define ZOO_REMOVE_WATCHES 18
+#define ZOO_CREATE_CONTAINER_OP 19
+#define ZOO_DELETE_CONTAINER_OP 20
 
 Review comment:
   You might not want to add the opcode for delete, because that is not a command which client is supposed to submit. You've only added support for creation anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services