[GitHub] [pulsar] lhotari opened a new pull request #11812: Fix graceful shutdown in docker-compose examples

[GitBox <gi...@apache.org>]

lhotari opened a new pull request #11812:
URL: https://github.com/apache/pulsar/pull/11812


   ### Motivation
   
   In the case #11768 , the docker-compose environment won't start after stopping it. Pulsar gets killed without a graceful shutdown. When investigating the reason, it was noticed that docker-compose examples are invalid. Instead of `bash -c "bin/pulsar standalone"`, the command should contain `exec`, for example `bash -c "exec bin/pulsar standalone"`.
   
   - Get OS signals passed to container process by using shell built-in "exec"
   - this is required so that the process running in the container is able to receive OS signals
     - explained in https://docs.docker.com/develop/develop-images/dockerfile_best-practices/
       and https://docs.docker.com/engine/reference/builder/#entrypoint
   - receiving SIGTERM signal is required for graceful shutdown.
   
   ### Modifications
   
   - replace `bin/pulsar` with `exec bin/pulsar` in docker-compose examples.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #11812: Fix graceful shutdown in docker-compose examples

[GitBox <gi...@apache.org>]

lhotari merged pull request #11812:
URL: https://github.com/apache/pulsar/pull/11812


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org