You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/16 06:50:08 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #5878: [HUDI-4259] Flink create avro schema not conformance to standards

danny0405 commented on code in PR #5878:
URL: https://github.com/apache/hudi/pull/5878#discussion_r898751821


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/AvroSchemaConverter.java:
##########
@@ -263,7 +263,7 @@ public static Schema convertToSchema(LogicalType logicalType, String rowName) {
           LogicalType fieldType = rowType.getTypeAt(i);
           SchemaBuilder.GenericDefault<Schema> fieldBuilder =
               builder.name(fieldName)
-                  .type(convertToSchema(fieldType, rowName + "_" + fieldName));
+                  .type(convertToSchema(fieldType, rowName + "." + fieldName));

Review Comment:
   The comment in line 174 should also be tweaked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org